Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[i18n] Added Arabic translation #1941

Closed
wants to merge 12 commits into from
Closed

[i18n] Added Arabic translation #1941

wants to merge 12 commits into from

Conversation

AlkindiX
Copy link

@RocketChat/ReactNative
This new pull request add Arabic translation to Rocket chat Reactive project.

@CLAassistant
Copy link

CLAassistant commented Mar 25, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@AlkindiX
Copy link
Author

Please Review

@diegolmello
Copy link
Member

Thanks for opening, @AlkindiX.
We'll take a look soon.

@diegolmello diegolmello mentioned this pull request May 22, 2020
Closed
abalhamoud
abalhamoud suggested changes Oct 4, 2020
View reviewed changes
Copy link
Contributor

@abalhamoud abalhamoud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor fixes and suggestions on the translation. :)

app/i18n/locales/ar.js Show resolved Hide resolved
app/i18n/locales/ar.js Outdated Show resolved Hide resolved
app/i18n/locales/ar.js Outdated Show resolved Hide resolved
app/i18n/locales/ar.js Outdated Show resolved Hide resolved
app/i18n/locales/ar.js Outdated Show resolved Hide resolved
app/i18n/locales/ar.js Outdated Show resolved Hide resolved
app/i18n/locales/ar.js Outdated Show resolved Hide resolved
app/i18n/locales/ar.js Outdated Show resolved Hide resolved
app/i18n/locales/ar.js Outdated Show resolved Hide resolved
app/i18n/locales/ar.js Outdated Show resolved Hide resolved
@diegolmello
Copy link
Member

Hey, @abalhamoud.
This PR is quite old, so there're missing keys.
Do you mind opening a new one?
I'll make sure @AlkindiX is marked as co-author.
Thank you, guys.

AlkindiX and others added 10 commits October 5, 2020 18:24
@AlkindiX @abalhamoud
Update app/i18n/locales/ar.js
af095e2 
Co-authored-by: Abdullah Alhamoud <10301923+abalhamoud@users.noreply.github.com>
@AlkindiX @abalhamoud
Update app/i18n/locales/ar.js
ab783a0 
Co-authored-by: Abdullah Alhamoud <10301923+abalhamoud@users.noreply.github.com>
@AlkindiX @abalhamoud
Update app/i18n/locales/ar.js
84fe492 
Co-authored-by: Abdullah Alhamoud <10301923+abalhamoud@users.noreply.github.com>
@AlkindiX @abalhamoud
Update app/i18n/locales/ar.js
8d022d9 
Co-authored-by: Abdullah Alhamoud <10301923+abalhamoud@users.noreply.github.com>
@AlkindiX @abalhamoud
Update app/i18n/locales/ar.js
3ca40b8 
Co-authored-by: Abdullah Alhamoud <10301923+abalhamoud@users.noreply.github.com>
@AlkindiX @abalhamoud
Update app/i18n/locales/ar.js
1aed55c 
Co-authored-by: Abdullah Alhamoud <10301923+abalhamoud@users.noreply.github.com>
@AlkindiX @abalhamoud
Update app/i18n/locales/ar.js
21234af 
Co-authored-by: Abdullah Alhamoud <10301923+abalhamoud@users.noreply.github.com>
@AlkindiX @abalhamoud
Update app/i18n/locales/ar.js
18de65c 
Co-authored-by: Abdullah Alhamoud <10301923+abalhamoud@users.noreply.github.com>
@AlkindiX @abalhamoud
Update app/i18n/locales/ar.js
684493d 
Co-authored-by: Abdullah Alhamoud <10301923+abalhamoud@users.noreply.github.com>
@AlkindiX @abalhamoud
Update app/i18n/locales/ar.js
2ad0442 
Co-authored-by: Abdullah Alhamoud <10301923+abalhamoud@users.noreply.github.com>
@AlkindiX
Copy link
Author

AlkindiX commented Oct 5, 2020

I forgot about this PR. It was a while ago. @abalhamoud thank you for your contribution. Too many commits to merge. @diegolmello you can close this commit and @abalhamoud to open a new one instead of this with all the corrections and new keys.

Thanks

AlkindiX
AlkindiX commented Oct 5, 2020
View reviewed changes
Copy link
Author

@AlkindiX AlkindiX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just reviewed most the changes

@abalhamoud
Copy link
Contributor

Sure @diegolmello I will open a new PR with the latest keys. Thanks to @AlkindiX for the contribution.

@AlkindiX
Copy link
Author

AlkindiX commented Oct 7, 2020

Closing this pull request

@AlkindiX AlkindiX closed this Oct 7, 2020
@abalhamoud
Copy link
Contributor

@diegolmello I have opened a new PR #2537 for the translation. Please check.

@diegolmello
Copy link
Member

I'm going to review it soon.
Thanks, guys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abalhamoud abalhamoud abalhamoud requested changes

Assignees
No one assigned
Labels
🌎 i18n 👀 needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlkindiX @CLAassistant @diegolmello @abalhamoud