feat: Android Different notification sounds for private group and direct messages #2511
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Different notification sounds for private group and direct messages
Issue(s)
This enhances the user experience improvements by #2507, #1451, RocketChat/push#2, and RocketChat/Rocket.Chat#19061.
How to test or reproduce
Send a message from another user
Previously: You'll get a generic sound from the phone manufacturer (if you're lucky) or silent (if manufacturer defaults to silent notification sound)
Now: You'll get a different sound based on whether it is 1) private group, 2) direct message, 3) public channel or general.
Notes:
Screenshots
Types of changes
Checklist
credits.md
for attributionsFurther comments
All sounds used are licensed under Creative Commons and without commercial restriction. See included
credits.md
for attributions.