Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Android Different notification sounds for private group and direct messages #2511

Closed
wants to merge 1 commit into from

Conversation

ceefour
Copy link
Contributor

@ceefour ceefour commented Sep 30, 2020

Proposed changes

Different notification sounds for private group and direct messages

Issue(s)

This enhances the user experience improvements by #2507, #1451, RocketChat/push#2, and RocketChat/Rocket.Chat#19061.

How to test or reproduce

  1. Send a message from another user

  2. Previously: You'll get a generic sound from the phone manufacturer (if you're lucky) or silent (if manufacturer defaults to silent notification sound)

    Now: You'll get a different sound based on whether it is 1) private group, 2) direct message, 3) public channel or general.

Notes:

  1. Only affects first install. User can still customize the sound for each category using Android per-app notification settings.
  2. Only affects Android >= 8.0. Previous versions and iOS are out of scope.

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable) -- See credits.md for attributions
  • Any dependent changes have been merged and published in downstream modules

Further comments

All sounds used are licensed under Creative Commons and without commercial restriction. See included credits.md for attributions.

Copy link
Member

@diegolmello diegolmello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.
I'm afraid this is something we shouldn't enforce in code.
If we do it in the future, we might have to let server's admin to choose the notification sound.
I'm closing for now and will reopen if necessary.

@ceefour
Copy link
Contributor Author

ceefour commented Oct 30, 2020

Hi @diegolmello can you reconsider?

"Enforcing" is not accurate as the sounds are always changeable regardless of this patch.

If and when in the future admins can choose sounds, the Rocket.Chat defaults are still there, though they will have the option to change some of them.

@diegolmello
Copy link
Member

Enforcing I meant static in code.
Again, we might add this ability in the future, but we have on plans to do it soon.
Thank you for your other push notification related PRs though :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants