[BUG] Fixed the issue #2531 #2541
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In app/containers/message/Reply.js added a View Contaier around the Attachment Touchable and Added a Markdown attribute with msg set to description of attachment to display the message if any.
Added an if statement to check if file description exists and if yes then add a markdown with value msg equal to the description. Also tested using 'yarn test -u' to add/update the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The app now shows the message entered with the pdf or other files on sending.
In app/containers/message/Reply.js added a View Container around the Attachment Touchable and Added a Markdown attribute with msg set to description of attachment to display the message if any.
Issue(s)
Fixing the issue #2531
How to test or reproduce
Screenshots
The text entered while sending the file is visible in the development version now (Refer to the latest attachment sent).
The same text is not visible in the production version (Refer to the latest attachment sent).
Types of changes
Checklist
Further comments
I am new to Opensource. Please let me know if I have done something wrong so that I can Fix It. Thank You!