Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Jitsi users unable to unmute #2623

Merged
merged 8 commits into from
Nov 12, 2020
Merged

[FIX] Jitsi users unable to unmute #2623

merged 8 commits into from
Nov 12, 2020

Conversation

djorkaeffalexandre
Copy link
Collaborator

@djorkaeffalexandre djorkaeffalexandre commented Nov 10, 2020

Proposed changes

Probably some commit after 2.10.2 was cherry picked when the sdk was builded on the last time, now I've set the branch to the specific tag v.2.10.2.
I've reverted some commits of jitsi-meet and regenerated the sdk, v.2.10.2.

Issue(s)

Close #2622

How to test or reproduce

  • Start a Jitsi call using two different devices
  • Unmute all users
  • You should hear yourself

Screenshots

image
Screen Shot 2020-11-11 at 5 30 12 PM

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Copy link
Member

@diegolmello diegolmello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diegolmello diegolmello merged commit 7af4bbb into develop Nov 12, 2020
@diegolmello diegolmello deleted the fix.jitsi branch November 12, 2020 19:35
@diegolmello diegolmello changed the title [FIX] Jitsi users being muted always [FIX] Jitsi users unable to unmute Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Users are always muted in Jitsi calls in iOS version 4.12.0.316
2 participants