Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Support client certificates for SSL (two-way authentication) (Android) #2624

Merged
merged 18 commits into from
Nov 30, 2020

Conversation

djorkaeffalexandre
Copy link
Collaborator

@djorkaeffalexandre djorkaeffalexandre commented Nov 10, 2020

Proposed changes

Implements TLS Client/mutual authentication with Certificate Pinning to Android devices.

Issue(s)

Close #1711

How to test or reproduce

Pin a certificate and connect to a server protected by a client ssl certificate.

  • Websocket
  • REST
  • Images
  • FastImage
  • WebView
  • RNFetchBlob
    This list consider what is implemented on iOS
  • Audio
  • Video

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Let's move changes of react-native and react-native-fast-image to our own forks.

@diegolmello diegolmello merged commit 155fc04 into develop Nov 30, 2020
@diegolmello diegolmello deleted the ssl-pinning branch November 30, 2020 17:00
@C1ean
Copy link

C1ean commented Dec 18, 2020

What about iOS app and 2FA with SSL support?

@diegolmello
Copy link
Member

@C1ean iOS has this feature since last year.

2FA with SSL support

Can you give us more details on a new issue?
Is it a feature request for the main repo?

@jangaraj
Copy link
Contributor

jangaraj commented Jan 5, 2021

IMHO this PR breaks SSO auth, where used IDP offers also optional mutual TLS authentication. I don't have any cert on my Android device and white SSO login page is generated (there is IDP login form in the previous app version). Do you have any recommendation how to investigate this from the user point of view?

@diegolmello
Copy link
Member

@jangaraj Can you open a new issue with detailed information?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TLS Client/mutual authentication
4 participants