[FIX] Whitelabel unable to find package name #2626
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The string "Notifications" is double translated, giving the strange output seen in issue #2625 when the language is set to non-English
The second file is the fix for #2614
Issue(s)
#2625 and #2614 which Github added to my existing PR instead of creating a second one ... see annotations beyond. Sorry, I'm a Github noob ;-)
How to test or reproduce
Screenshots
See #2625
Types of changes
Checklist
Further comments
This is my first PR on Github ... I also saw that #2614 was still unfixed in 4.12.0, so I've added that as well in a second step. I thought it would open a second PR, instead it added this change to the existing one. Sorry, I have no idea how to tell Github to make 2 PR's out of it, but I wanted to be sure that the fix for #2614 finds its way into future versions.