Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Model columns misplaced #2640

Merged
merged 1 commit into from
Nov 12, 2020
Merged

[FIX] Model columns misplaced #2640

merged 1 commit into from
Nov 12, 2020

Conversation

diegolmello
Copy link
Member

@diegolmello diegolmello commented Nov 12, 2020

Proposed changes

login_email_password and show_message_in_main_thread placed on wrong User model.

Issue(s)

How to test or reproduce

login_email_password

  • Login via email password
  • Reload the app to cause a resume request
  • Logout
  • App should not ask to clear cookies

  • Login via OAuth
  • Reload the app to cause a resume request
  • Logout
  • App should ask to clear cookies

show_message_in_main_thread

  • Play with the user preference and the app should show/hide messages on the main thread accordingly
    image

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Copy link
Collaborator

@djorkaeffalexandre djorkaeffalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diegolmello diegolmello merged commit 80d6e0d into develop Nov 12, 2020
@diegolmello diegolmello deleted the fix.database-issue branch November 12, 2020 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants