Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NEW] Channel actions #2644

Merged
merged 27 commits into from
Nov 30, 2020
Merged

[NEW] Channel actions #2644

merged 27 commits into from
Nov 30, 2020

Conversation

diegolmello
Copy link
Member

@diegolmello diegolmello commented Nov 13, 2020 •
edited
Loading

Proposed changes

Adds ability to:

  • Set/unset channel leader
  • Set/unset channel moderator
  • Set/unset channel owner
  • Remove user from room
  • Ignore user

Issue(s)

Closes #2545

How to test or reproduce

Screenshots

image

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@lgtm-com
Copy link

lgtm-com bot commented Nov 13, 2020

This pull request introduces 1 alert when merging f0dddf2 into 079d239 - view on LGTM.com

new alerts:

  • 1 for Potentially inconsistent state update

djorkaeffalexandre
djorkaeffalexandre requested changes Nov 20, 2020
View reviewed changes
app/lib/rocketchat.js Outdated Show resolved Hide resolved
app/views/RoomMembersView/index.js Outdated Show resolved Hide resolved
@ankar84 ankar84 mentioned this pull request Nov 25, 2020
Closed
@lgtm-com
Copy link

lgtm-com bot commented Nov 30, 2020

This pull request introduces 1 alert when merging f284d17 into 155fc04 - view on LGTM.com

new alerts:

  • 1 for Potentially inconsistent state update

@lgtm-com
Copy link

lgtm-com bot commented Nov 30, 2020

This pull request introduces 1 alert when merging 3504383 into 155fc04 - view on LGTM.com

new alerts:

  • 1 for Potentially inconsistent state update

djorkaeffalexandre
djorkaeffalexandre approved these changes Nov 30, 2020
View reviewed changes
Copy link
Collaborator

@djorkaeffalexandre djorkaeffalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diegolmello diegolmello merged commit 40490ea into develop Nov 30, 2020
@diegolmello diegolmello deleted the new.room-permissions-actions branch November 30, 2020 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djorkaeffalexandre djorkaeffalexandre djorkaeffalexandre approved these changes

Assignees
No one assigned
Labels
🎉 feature 👀 needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[New] Add all available in web version channel actions to mobile application
2 participants
@diegolmello @djorkaeffalexandre