Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Share extension and save image not working on Android 10 #2651

Merged
merged 1 commit into from
Nov 17, 2020
Merged

[FIX] Share extension and save image not working on Android 10 #2651

merged 1 commit into from
Nov 17, 2020

Conversation

diegolmello
Copy link
Member

Proposed changes

Opt-out of scoped storage https://developer.android.com/training/data-storage/use-cases#opt-out-scoped-storage

Issue(s)

Closes #2456

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

djorkaeffalexandre
djorkaeffalexandre approved these changes Nov 17, 2020
View reviewed changes
Copy link
Collaborator

@djorkaeffalexandre djorkaeffalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diegolmello diegolmello merged commit ded7391 into develop Nov 17, 2020
@diegolmello diegolmello deleted the fix.android-10-files branch November 17, 2020 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djorkaeffalexandre djorkaeffalexandre djorkaeffalexandre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't save pictures on Android 10
2 participants
@diegolmello @djorkaeffalexandre