Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Support RTL #2656

Merged
merged 15 commits into from
Nov 30, 2020
Merged

[NEW] Support RTL #2656

merged 15 commits into from
Nov 30, 2020

Conversation

djorkaeffalexandre
Copy link
Collaborator

@djorkaeffalexandre djorkaeffalexandre commented Nov 19, 2020

Proposed changes

Support RTL mode.

Issue(s)

How to test or reproduce

  • Use a language where RTL is required (Arabic)

Screenshots

Screen Shot 2020-11-19 at 9 47 40 AM
Screen Shot 2020-11-19 at 9 49 15 AM
Screen Shot 2020-11-19 at 9 49 20 AM
Screen Shot 2020-11-19 at 9 52 04 AM
Screen Shot 2020-11-19 at 9 53 54 AM
Screen Shot 2020-11-19 at 9 54 00 AM
Screen Shot 2020-11-19 at 9 54 17 AM

2020-11-19T15_01_56-6 370Z
2020-11-19T15_01_56-5 370Z
2020-11-19T15_01_56-4 370Z
2020-11-19T15_01_44 415Z
2020-11-19T15_01_56 370Z
2020-11-19T15_01_56-3 370Z
2020-11-19T15_01_56-2 370Z

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

There are some limitations with RTL mode like

  • Custom emojis are always rendered on left (limitation with image inside a text on react-native) (iOS)

@djorkaeffalexandre djorkaeffalexandre marked this pull request as ready for review November 20, 2020 14:18
@djorkaeffalexandre djorkaeffalexandre changed the title [WIP] [NEW] RTL [NEW] RTL Nov 20, 2020
@diegolmello diegolmello changed the title [NEW] RTL [NEW] Support RTL Nov 30, 2020
@diegolmello diegolmello merged commit 10ba9d5 into develop Nov 30, 2020
@diegolmello diegolmello deleted the new.rtl branch November 30, 2020 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants