Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Light theme not working on Android with Dark Theme set #2675

Merged
merged 2 commits into from
Dec 1, 2020

Conversation

djorkaeffalexandre
Copy link
Collaborator

Proposed changes

Android 10 has a feature called forceDark that override some views/icons colors when the device is on Dark mode, we should disable this feature since we have in-app themes that can be not related to the OS theme.
facebook/react-native#29387 (comment)

Issue(s)

How to test or reproduce

  • Set device to Dark Theme
  • Set app theme to Light (it should be light)
  • Set app to automatic (it should be dark)

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@diegolmello diegolmello merged commit 06521d1 into develop Dec 1, 2020
@diegolmello diegolmello deleted the fix.dark-theme branch December 1, 2020 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants