Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Thread message flickering while thread parent isn't found #2676

Merged
merged 2 commits into from
Dec 1, 2020

Conversation

djorkaeffalexandre
Copy link
Collaborator

Proposed changes

We don't need to check the previous message for a thread sequential.

Issue(s)

How to test or reproduce

  • Create a new channel (not on the app)
  • Send a first message
  • Send a second message replying the first one (to create a thread) containing some other message on the content (to add a Reply component)
  • Open the channel on the app (you might have to clear cache before doing this)

Screenshots

Before

After

All things are working as expected after the change
Screen Shot 2020-11-26 at 10 48 46 AM

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@diegolmello diegolmello merged commit 13c3bc3 into develop Dec 1, 2020
@diegolmello diegolmello deleted the fix.thread-preview branch December 1, 2020 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants