Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RoomsListView re-render #304

Merged
merged 2 commits into from
May 24, 2018
Merged

RoomsListView re-render #304

merged 2 commits into from
May 24, 2018

Conversation

diegolmello
Copy link
Member

@RocketChat/ReactNative

  • Removed unnecessary re-renders on RoomsListView

@diegolmello diegolmello force-pushed the rooms-list-rerender branch from d3b7592 to f3180b3 Compare May 24, 2018 19:37
@ggazzo ggazzo merged commit 8f90565 into develop May 24, 2018
@ggazzo ggazzo deleted the rooms-list-rerender branch May 24, 2018 20:17
@codecov-io
Copy link

Codecov Report

Merging #304 into develop will decrease coverage by 0.82%.
The diff coverage is 25%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #304      +/-   ##
===========================================
- Coverage    60.95%   60.13%   -0.83%     
===========================================
  Files           12       12              
  Lines          146      148       +2     
  Branches        23       24       +1     
===========================================
  Hits            89       89              
- Misses          49       50       +1     
- Partials         8        9       +1
Impacted Files Coverage Δ
app/presentation/RoomItem.js 55% <25%> (-1.9%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 182ab69...f3180b3. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants