Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Wrong message when room is closed by the Guest #3289

Merged
merged 4 commits into from
Aug 23, 2021

Conversation

reinaldonetof
Copy link
Contributor

@reinaldonetof reinaldonetof commented Jul 21, 2021

Proposed changes

Move the agent to the Room List View and don't show the wrong/unnecessary message

Issue(s)

On Mobile app side, a wrong/unnecessary message is threw

How to test or reproduce

1 - Activate Omnicahnnel -> https://docs.rocket.chat/guides/omnichannel-guides/omnichannel-admins-guide
2 - Start a new chat through Livechat
3 - Take the Chat in the queue
4 - On Livechat, click on Options button
5 - Click Finish this chat button
6 - On Mobile app side, a wrong/unnecessary message is threw

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Copy link
Contributor

@gerzonc gerzonc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diegolmello diegolmello merged commit 5c6b463 into develop Aug 23, 2021
@diegolmello diegolmello deleted the fix.message-when-room-closed branch August 23, 2021 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants