[FIX] Server settings API limit increase #3324
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This change passes a count limit (100) to the settings.public API call in order to ensure ALL server settings are retrieved by the app. I'm guessing the number of these has increased over time (?) and the default limit of 50 does not provide an appropriate amount of records (I believe there are 53 returned on our server instance).
Issue(s)
How to test or reproduce
In testing, we noticed that a few of the server side settings (e.g. "UI_Use_Real_Name") were not being picked up on the app (they were undefined). After much tracking, I found out that these settings were being excluded due to an insufficient default record limit in the API call.
Screenshots
Types of changes
Checklist
Further comments
server-settings-api-limit-increase