Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Server settings API limit increase #3324

Closed

Conversation

cprice-kgi
Copy link
Contributor

Proposed changes

This change passes a count limit (100) to the settings.public API call in order to ensure ALL server settings are retrieved by the app. I'm guessing the number of these has increased over time (?) and the default limit of 50 does not provide an appropriate amount of records (I believe there are 53 returned on our server instance).

Issue(s)

How to test or reproduce

In testing, we noticed that a few of the server side settings (e.g. "UI_Use_Real_Name") were not being picked up on the app (they were undefined). After much tracking, I found out that these settings were being excluded due to an insufficient default record limit in the API call.

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

server-settings-api-limit-increase

@diegolmello
Copy link
Member

Thanks for opening, but it was fixed on #3277

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants