Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Bugsnag and Analytics opt-out #3335

Merged
merged 8 commits into from
Aug 23, 2021
Merged

Conversation

reinaldonetof
Copy link
Contributor

@reinaldonetof reinaldonetof commented Aug 19, 2021

Proposed changes

Fix Analytics and Crash Reporting opt-out. In addition, fix the flow for both after changing the setting and after restarting the app, disable/enable features on switch changed, and remove the redux.

Issue(s)

Enabled and disable analytics and bugsnag isn't work properly when restarting the app and the approach work with bugsnag changed after update the library, which was causing errors.

How to test or reproduce

  • Go to Security And Privacy View
  • Disable the Log analytics events or Send crash report
  • Then, when you close the app and open it again, your last choice should be the same when reopening the app
  • In addition, if you have access to bugsnag or analytics, when you disable anyone of them, there should not report any error or events to their workspace

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Copy link
Member

@diegolmello diegolmello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! LGTM :)

@diegolmello diegolmello merged commit 7cd19b6 into develop Aug 23, 2021
@diegolmello diegolmello deleted the fix.bugsnag-analytics branch August 23, 2021 14:15
@diegolmello diegolmello changed the title [FIX] Enabled and disable the report to bugsnag and analytics [FIX] Bugsnag and Analytics opt-out Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants