Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Changed navigation library to react-navigation. #41

Merged
merged 19 commits into from
Sep 21, 2017
Merged

Conversation

gilmarsquinelato
Copy link
Contributor

Refactoring on sagas to remove navigation navigation flow do it in views.
Added new modal library.
Renamed view files to the same name of their classes.
Added support to redux-devtools using the chrome extension through Remote devtools menu.
Some components was refactored to reduce complexity and more legibility.

Refactoring on sagas to remove navigation navigation flow do it in views.
Added new modal library.
Renamed view files to the same name of their classes.
Added support to redux-devtools using the chrome extension through Remote devtools menu.
Some components was refactored to reduce complexity and more legibility.
@ggazzo ggazzo self-requested a review September 11, 2017 13:39
Copy link
Member

@ggazzo ggazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gilmarsquinelato we must be able to add/use multiple servers.

@gilmarsquinelato
Copy link
Contributor Author

@ggazzo I've added a drawer menu containing all added servers using realm, just access and check it out :).

@codecov-io
Copy link

codecov-io commented Sep 13, 2017

Codecov Report

❗ No coverage uploaded for pull request base (develop@332d7da). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             develop    #41   +/-   ##
========================================
  Coverage           ?   100%           
========================================
  Files              ?      6           
  Lines              ?     44           
  Branches           ?      9           
========================================
  Hits               ?     44           
  Misses             ?      0           
  Partials           ?      0
Impacted Files Coverage Δ
app/containers/Avatar.js 100% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 332d7da...2457c14. Read the comment docs.

ggazzo
ggazzo previously approved these changes Sep 21, 2017
@ggazzo ggazzo changed the title Changed navigation library to react-navigation. [NEW] Changed navigation library to react-navigation. Sep 21, 2017
@ggazzo ggazzo merged commit d55db0f into develop Sep 21, 2017
@ggazzo ggazzo deleted the navigation branch September 21, 2017 17:08
djorkaeffalexandre pushed a commit that referenced this pull request Aug 9, 2019
* Changed navigation library to react-navigation.
Refactoring on sagas to remove navigation navigation flow do it in views.
Added new modal library.
Renamed view files to the same name of their classes.
Added support to redux-devtools using the chrome extension through Remote devtools menu.
Some components was refactored to reduce complexity and more legibility.

* Remove react-native-navigation from Android

* Adding servers to drawer menu, allowing server switch.

* Sidebar component

* opss :x fix add server

* opss :x fix add server

* Fixed add server navigation issues, fixed empty and slow Rooms List and Chat Messages

* Disable cleanup everytime

* some fixes

* some fixes

*  fix?

* .

* Fixed logo not displaying when app is loading or signing to server

* Fixed logo in loading and login

* Update LoginView.js

* Update PublicRoutes.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants