This repository has been archived by the owner on Jun 7, 2020. It is now read-only.
[NEW] Add support to Broadcast rooms #1657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelks
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #1657 +/- ##
===========================================
+ Coverage 36.65% 36.71% +0.06%
===========================================
Files 298 301 +3
Lines 14036 14156 +120
===========================================
+ Hits 5145 5198 +53
- Misses 8891 8958 +67
Continue to review full report at Codecov.
|
rafaelks
changed the title
rafaelks
commented
May 10, 2018
| @@ -10,8 +10,8 @@ import RealmSwift | |||
| import SlackTextViewController | |||
| import SimpleImageViewer | |||
|
|
|||
| private typealias NibCellIndentifier = (nibName: String, cellIdentifier: String) | |||
| private let kEmptyCellIdentifier = "kEmptyCellIdentifier" | |||
There was a problem hiding this comment.
Need to revert this change.
rafaelks
changed the title
cardoso
reviewed
May 14, 2018
| @@ -23,7 +23,7 @@ fileprivate extension SubscriptionType { | |||
| } | |||
| } | |||
|
|
|||
| class SubscriptionFilesRequest: APIRequest { | |||
| final class SubscriptionFilesRequest: APIRequest { | |||
| @@ -11,15 +11,17 @@ import Foundation | |||
| extension AuthViewController { | |||
| internal func handleAuthenticationResponse(_ response: LoginResponse) { | |||
| if case let .resource(resource) = response, let error = resource.error { | |||
| stopLoading() | |||
| DispatchQueue.main.async { [weak self] in | |||
| @@ -0,0 +1,59 @@ | |||
| // | |||
| // SubscriptionRolesRequest.swift | |||
|
|
||
| extension ChatViewController { | ||
|
|
||
| func updateSubscriptionRoles() { |
There was a problem hiding this comment.
I think this would be a good method for SubscriptionsClient, with realm and subscription as parameters, instead of being in the ViewController. This would make it more testable and reusable.
I can do it in another PR if you want.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/ios
Closes #1654
Progress
channels.roles&groups.rolesRocket.Chat#10607)Demo