Skip to content
This repository has been archived by the owner on Jun 7, 2020. It is now read-only.

[NEW][WIP] Added unhiding channel after hiding. #2566

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

tmbiOS
Copy link

@tmbiOS tmbiOS commented Feb 26, 2019

@RocketChat/ios
Need help: can't reload subscriptions after opening room.

Closes #2158

@CLAassistant
Copy link

CLAassistant commented Feb 26, 2019

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Feb 26, 2019

Codecov Report

Merging #2566 into develop will decrease coverage by 0.05%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2566      +/-   ##
===========================================
- Coverage    26.49%   26.44%   -0.06%     
===========================================
  Files          456      457       +1     
  Lines        16903    16940      +37     
===========================================
  Hits          4479     4479              
- Misses       12424    12461      +37
Impacted Files Coverage Δ
Rocket.Chat/API/Clients/SubscriptionsClient.swift 62.8% <0%> (-4.21%) ⬇️
...ocket.Chat/API/Requests/Room/RoomOpenRequest.swift 0% <0%> (ø)
...ubscriptionsList/SubscriptionsViewController.swift 2.46% <0%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 176750f...c0ed547. Read the comment docs.

@tmbiOS
Copy link
Author

tmbiOS commented Feb 28, 2019

@RocketChat/ios
Need help: can't reload subscriptions after opening room.

@rafaelks
Copy link
Contributor

@tmbiOS Please try adding also the auth property to the Subscription, using Auth.isAuthenticated() method to get the correct instance.

@rafaelks rafaelks added this to the 3.5.0 milestone Mar 22, 2019
@rafaelks
Copy link
Contributor

rafaelks commented Apr 2, 2019

@tmbiOS Do you have plans to finish this PR at any time? Thank you!

@tmbiOS
Copy link
Author

tmbiOS commented Apr 3, 2019

@tmbiOS Do you have plans to finish this PR at any time? Thank you!

Hi, @rafaelks !
I'm planning to finish PR next week (and open new PR). Should I write the tests?

@rafaelks
Copy link
Contributor

rafaelks commented Apr 3, 2019

@tmbiOS Yes, please! :-)

@rafaelks rafaelks modified the milestones: 3.4.1, 3.5.0 Apr 5, 2019
@rafaelks rafaelks modified the milestones: 3.5.0, 3.6.0 May 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Room stays hidden
3 participants