Skip to content

Commit

Permalink
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into feat…
Browse files Browse the repository at this point in the history
…/attachment-file

* 'develop' of github.com:RocketChat/Rocket.Chat: (33 commits)
  Chore: fix EmailInbox intermittent e2e tests (#27573)
  [IMPROVE] Authorize search of custom fields on `users.list` (#27423)
  Chore:  Threads as React components (#27524)
  [NEW] Upload service (#27543)
  [FIX] Fix emoji appearance on sidebar (#27580)
  [FIX] RoomLeader status not working (#27576)
  [FIX] Announcement banner link opening in the same page (#27554)
  Bump version to 5.4.1
  [FIX] Custom languages not being applied to i18next (#27557)
  [FIX] Registration and Login placeholders not being used (#27558)
  [FIX] Fix Login with Show default form disabled (#27475)
  [FIX] Message Actions menu does not close upon choosing an action (#27328)
  Chore: Deprecate unused omnichannel API (#27538)
  [FIX] Pagination not working on current chats (#27432)
  [FIX] Custom languages not being applied to i18next (#27557)
  [FIX] Registration and Login placeholders not being used (#27558)
  [FIX] Message Actions menu does not close upon choosing an action (#27328)
  Chore: Deprecate unused omnichannel API (#27538)
  Regression: Add button-icon-disabled-color to the palette (#27522)
  Chore: Refactor CreateChannelModal (#27469)
  ...
  • Loading branch information
gabriellsh committed Dec 20, 2022
2 parents eea6b03 + af9373f commit 1d09a49
Show file tree
Hide file tree
Showing 215 changed files with 4,552 additions and 3,637 deletions.
74 changes: 74 additions & 0 deletions .github/history.json
Original file line number Diff line number Diff line change
Expand Up @@ -97999,6 +97999,80 @@
"5.0"
],
"pull_requests": []
},
"5.4.1": {
"node_version": "14.19.3",
"npm_version": "6.14.17",
"mongo_versions": [
"4.2",
"4.4",
"5.0"
],
"pull_requests": [
{
"pr": "27557",
"title": "[FIX] Custom languages not being applied to i18next",
"userLogin": "ggazzo",
"milestone": "5.4.1",
"contributors": [
"ggazzo",
"kodiakhq[bot]",
"web-flow"
]
},
{
"pr": "27558",
"title": "[FIX] Registration and Login placeholders not being used",
"userLogin": "ggazzo",
"milestone": "5.4.1",
"contributors": [
"ggazzo"
]
},
{
"pr": "27475",
"title": "[FIX] Fix Login with Show default form disabled",
"userLogin": "ggazzo",
"milestone": "5.4.1",
"contributors": [
"ggazzo"
]
},
{
"pr": "27328",
"title": "[FIX] Message Actions menu does not close upon choosing an action",
"userLogin": "filipemarins",
"milestone": "5.4.1",
"contributors": [
"filipemarins",
"yash-rajpal",
"hugocostadev",
"kodiakhq[bot]",
"web-flow"
]
},
{
"pr": "27538",
"title": "Chore: Deprecate unused omnichannel API",
"userLogin": "murtaza98",
"milestone": "5.4.1",
"contributors": [
"murtaza98"
]
},
{
"pr": "27432",
"title": "[FIX] Pagination not working on current chats",
"userLogin": "MartinSchoeler",
"milestone": "5.4.1",
"contributors": [
"MartinSchoeler",
"aleksandernsilva",
"kodiakhq[bot]",
"web-flow"
]
}
]
}
},
"5.4.0-rc.0": {
Expand Down
65 changes: 52 additions & 13 deletions HISTORY.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,43 @@

# 5.4.1
`2022-12-16 · 5 🐛 · 1 🔍 · 7 👩‍💻👨‍💻`

### Engine versions
- Node: `14.19.3`
- NPM: `6.14.17`
- MongoDB: `4.2, 4.4, 5.0`

### 🐛 Bug fixes


- Custom languages not being applied to i18next ([#27557](https://github.com/RocketChat/Rocket.Chat/pull/27557))

- Fix Login with Show default form disabled ([#27475](https://github.com/RocketChat/Rocket.Chat/pull/27475))

- Message Actions menu does not close upon choosing an action ([#27328](https://github.com/RocketChat/Rocket.Chat/pull/27328))

- Pagination not working on current chats ([#27432](https://github.com/RocketChat/Rocket.Chat/pull/27432))

- Registration and Login placeholders not being used ([#27558](https://github.com/RocketChat/Rocket.Chat/pull/27558))

<details>
<summary>🔍 Minor changes</summary>


- Chore: Deprecate unused omnichannel API ([#27538](https://github.com/RocketChat/Rocket.Chat/pull/27538))

</details>

### 👩‍💻👨‍💻 Core Team 🤓

- [@MartinSchoeler](https://github.com/MartinSchoeler)
- [@aleksandernsilva](https://github.com/aleksandernsilva)
- [@filipemarins](https://github.com/filipemarins)
- [@ggazzo](https://github.com/ggazzo)
- [@hugocostadev](https://github.com/hugocostadev)
- [@murtaza98](https://github.com/murtaza98)
- [@yash-rajpal](https://github.com/yash-rajpal)

# 5.4.0
`2022-12-05 · 9 🎉 · 13 🚀 · 61 🐛 · 87 🔍 · 57 👩‍💻👨‍💻`

Expand Down Expand Up @@ -392,11 +431,11 @@
![Screenshot from 2021-01-28 03-47-19](https://user-images.githubusercontent.com/38764067/106062371-b0e97300-611c-11eb-97de-1ff4c668a4c8.png)
![Screenshot from 2021-01-28 03-47-55](https://user-images.githubusercontent.com/38764067/106062374-b21aa000-611c-11eb-83db-93a3d0858d46.png)

- User approval email doesn't display username and e-mail when user logs in with OAuth ([#27111](https://github.com/RocketChat/Rocket.Chat/pull/27111))
- User approval email doesn't display username and e-mail when user logs in with OAuth ([#27111](https://github.com/RocketChat/Rocket.Chat/pull/27111) by [@carlosrodrigues94](https://github.com/carlosrodrigues94))

- User auto complete breaks on enter key press ([#27213](https://github.com/RocketChat/Rocket.Chat/pull/27213))

- User email address does not change when provisioned by OAuth ([#27148](https://github.com/RocketChat/Rocket.Chat/pull/27148))
- User email address does not change when provisioned by OAuth ([#27148](https://github.com/RocketChat/Rocket.Chat/pull/27148) by [@carlosrodrigues94](https://github.com/carlosrodrigues94))

- UserCard not opening inside Threads ([#27096](https://github.com/RocketChat/Rocket.Chat/pull/27096))

Expand Down Expand Up @@ -710,6 +749,7 @@
- [@TedsCabin](https://github.com/TedsCabin)
- [@aKn1ghtOut](https://github.com/aKn1ghtOut)
- [@aswinidev](https://github.com/aswinidev)
- [@carlosrodrigues94](https://github.com/carlosrodrigues94)
- [@dependabot[bot]](https://github.com/dependabot[bot])
- [@edward-raven](https://github.com/edward-raven)
- [@eltociear](https://github.com/eltociear)
Expand All @@ -735,7 +775,6 @@
- [@MarcosSpessatto](https://github.com/MarcosSpessatto)
- [@MartinSchoeler](https://github.com/MartinSchoeler)
- [@aleksandernsilva](https://github.com/aleksandernsilva)
- [@carlosrodrigues94](https://github.com/carlosrodrigues94)
- [@casalsgh](https://github.com/casalsgh)
- [@cauefcr](https://github.com/cauefcr)
- [@d-gubert](https://github.com/d-gubert)
Expand Down Expand Up @@ -1814,7 +1853,7 @@

This PR fixes an issue that was happening when an invalid token was passed on SlackBridge, basically the app crashes because the error was not being handled

- Slash commands description as undefined ([#26372](https://github.com/RocketChat/Rocket.Chat/pull/26372))
- Slash commands description as undefined ([#26372](https://github.com/RocketChat/Rocket.Chat/pull/26372) by [@carlosrodrigues94](https://github.com/carlosrodrigues94))

- SMS service check ([#26558](https://github.com/RocketChat/Rocket.Chat/pull/26558))

Expand Down Expand Up @@ -1850,7 +1889,7 @@

- Chore: Accounts/token to TS ([#26434](https://github.com/RocketChat/Rocket.Chat/pull/26434))

- Chore: Add end-to-end tests to teams listing in the `directory` endpoint ([#26347](https://github.com/RocketChat/Rocket.Chat/pull/26347))
- Chore: Add end-to-end tests to teams listing in the `directory` endpoint ([#26347](https://github.com/RocketChat/Rocket.Chat/pull/26347) by [@carlosrodrigues94](https://github.com/carlosrodrigues94))

- Chore: Add license env var to ee tests ([#26650](https://github.com/RocketChat/Rocket.Chat/pull/26650))

Expand Down Expand Up @@ -2172,6 +2211,7 @@
### 👩‍💻👨‍💻 Contributors 😍

- [@Karting06](https://github.com/Karting06)
- [@carlosrodrigues94](https://github.com/carlosrodrigues94)
- [@imyaman](https://github.com/imyaman)
- [@pierreozoux](https://github.com/pierreozoux)
- [@shrinish123](https://github.com/shrinish123)
Expand All @@ -2185,7 +2225,6 @@
- [@MartinSchoeler](https://github.com/MartinSchoeler)
- [@albuquerquefabio](https://github.com/albuquerquefabio)
- [@aleksandernsilva](https://github.com/aleksandernsilva)
- [@carlosrodrigues94](https://github.com/carlosrodrigues94)
- [@casalsgh](https://github.com/casalsgh)
- [@cauefcr](https://github.com/cauefcr)
- [@d-gubert](https://github.com/d-gubert)
Expand Down Expand Up @@ -2632,7 +2671,7 @@
Demo gif:
![privacy-tab](https://user-images.githubusercontent.com/43561537/173878394-333057d4-3c7e-434e-a3ca-d3e08f33c7bc.gif)

- Matrix Federation UX improvements ([#25847](https://github.com/RocketChat/Rocket.Chat/pull/25847))
- Matrix Federation UX improvements ([#25847](https://github.com/RocketChat/Rocket.Chat/pull/25847) by [@carlosrodrigues94](https://github.com/carlosrodrigues94))

- Message Template React Component ([#23971](https://github.com/RocketChat/Rocket.Chat/pull/23971))

Expand Down Expand Up @@ -2702,7 +2741,7 @@

- Add tooltip to sidebar room menu ([#24405](https://github.com/RocketChat/Rocket.Chat/pull/24405) by [@Himanshu664](https://github.com/Himanshu664))

- add warnings for federation setup ([#25684](https://github.com/RocketChat/Rocket.Chat/pull/25684))
- add warnings for federation setup ([#25684](https://github.com/RocketChat/Rocket.Chat/pull/25684) by [@carlosrodrigues94](https://github.com/carlosrodrigues94))

- Added MaxNickNameLength and MaxBioLength constants ([#25231](https://github.com/RocketChat/Rocket.Chat/pull/25231) by [@aakash-gitdev](https://github.com/aakash-gitdev))

Expand Down Expand Up @@ -3926,7 +3965,7 @@

- Regression: Federated users not showing as federated in Room Members ([#26249](https://github.com/RocketChat/Rocket.Chat/pull/26249))

- Regression: fix `directory` endpoint not listing teams ([#26310](https://github.com/RocketChat/Rocket.Chat/pull/26310))
- Regression: fix `directory` endpoint not listing teams ([#26310](https://github.com/RocketChat/Rocket.Chat/pull/26310) by [@carlosrodrigues94](https://github.com/carlosrodrigues94))

- Regression: Fix app icons breaking UI ([#26278](https://github.com/RocketChat/Rocket.Chat/pull/26278))

Expand Down Expand Up @@ -4081,7 +4120,7 @@

### I'm definitely open for better looking alternatives. Please leave a comment if you have a better solution to share.

- Regression: Matrix Federation regressions ([#26283](https://github.com/RocketChat/Rocket.Chat/pull/26283))
- Regression: Matrix Federation regressions ([#26283](https://github.com/RocketChat/Rocket.Chat/pull/26283) by [@carlosrodrigues94](https://github.com/carlosrodrigues94))

- Regression: Messages in new message template Crashing. ([#25327](https://github.com/RocketChat/Rocket.Chat/pull/25327))

Expand Down Expand Up @@ -4268,6 +4307,7 @@
- [@Sh0uld](https://github.com/Sh0uld)
- [@aakash-gitdev](https://github.com/aakash-gitdev)
- [@amolghode1981](https://github.com/amolghode1981)
- [@carlosrodrigues94](https://github.com/carlosrodrigues94)
- [@cuonghuunguyen](https://github.com/cuonghuunguyen)
- [@dependabot[bot]](https://github.com/dependabot[bot])
- [@divinespear](https://github.com/divinespear)
Expand All @@ -4293,7 +4333,6 @@
- [@alansikora](https://github.com/alansikora)
- [@albuquerquefabio](https://github.com/albuquerquefabio)
- [@aleksandernsilva](https://github.com/aleksandernsilva)
- [@carlosrodrigues94](https://github.com/carlosrodrigues94)
- [@cauefcr](https://github.com/cauefcr)
- [@csuadev](https://github.com/csuadev)
- [@d-gubert](https://github.com/d-gubert)
Expand Down Expand Up @@ -4605,7 +4644,7 @@

- Add tooltip to sidebar room menu ([#24405](https://github.com/RocketChat/Rocket.Chat/pull/24405) by [@Himanshu664](https://github.com/Himanshu664))

- add warnings for federation setup ([#25684](https://github.com/RocketChat/Rocket.Chat/pull/25684))
- add warnings for federation setup ([#25684](https://github.com/RocketChat/Rocket.Chat/pull/25684) by [@carlosrodrigues94](https://github.com/carlosrodrigues94))

- Added MaxNickNameLength and MaxBioLength constants ([#25231](https://github.com/RocketChat/Rocket.Chat/pull/25231) by [@aakash-gitdev](https://github.com/aakash-gitdev))

Expand Down Expand Up @@ -5277,6 +5316,7 @@
- [@Himanshu664](https://github.com/Himanshu664)
- [@aakash-gitdev](https://github.com/aakash-gitdev)
- [@amolghode1981](https://github.com/amolghode1981)
- [@carlosrodrigues94](https://github.com/carlosrodrigues94)
- [@cuonghuunguyen](https://github.com/cuonghuunguyen)
- [@dependabot[bot]](https://github.com/dependabot[bot])
- [@divinespear](https://github.com/divinespear)
Expand All @@ -5299,7 +5339,6 @@
- [@alansikora](https://github.com/alansikora)
- [@albuquerquefabio](https://github.com/albuquerquefabio)
- [@aleksandernsilva](https://github.com/aleksandernsilva)
- [@carlosrodrigues94](https://github.com/carlosrodrigues94)
- [@cauefcr](https://github.com/cauefcr)
- [@d-gubert](https://github.com/d-gubert)
- [@debdutdeb](https://github.com/debdutdeb)
Expand Down
7 changes: 7 additions & 0 deletions _templates/service/new/.eslintrc.json.ejs.t
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
to: ee/apps/<%= name %>/.eslintrc.json
---
{
"extends": ["@rocket.chat/eslint-config"],
"ignorePatterns": ["**/dist"]
}
51 changes: 51 additions & 0 deletions _templates/service/new/package.json.ejs.t
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
---
to: ee/apps/<%= name %>/package.json
---
{
"name": "@rocket.chat/<%= name.toLowerCase() %>",
"private": true,
"version": "0.1.0",
"description": "Rocket.Chat service",
"scripts": {
"build": "tsc -p tsconfig.json",
"ms": "TRANSPORTER=${TRANSPORTER:-TCP} MONGO_URL=${MONGO_URL:-mongodb://localhost:3001/meteor} ts-node --files src/service.ts",
"test": "echo \"Error: no test specified\" && exit 1",
"lint": "eslint src",
"typecheck": "tsc --noEmit --skipLibCheck -p tsconfig.json"
},
"keywords": [
"rocketchat"
],
"author": "Rocket.Chat",
"dependencies": {
"@rocket.chat/core-typings": "workspace:^",
"@rocket.chat/emitter": "0.31.22",
"@rocket.chat/model-typings": "workspace:^",
"@rocket.chat/models": "workspace:^",
"@rocket.chat/rest-typings": "workspace:^",
"@rocket.chat/string-helpers": "0.31.22",
"@types/node": "^14.18.21",
"ejson": "^2.2.2",
"eventemitter3": "^4.0.7",
"fibers": "^5.0.3",
"mem": "^8.1.1",
"moleculer": "^0.14.21",
"mongodb": "^4.12.1",
"nats": "^2.4.0",
"pino": "^8.4.2",
"polka": "^0.5.2"
},
"devDependencies": {
"@rocket.chat/eslint-config": "workspace:^",
"@types/eslint": "^8.4.10",
"@types/polka": "^0.5.4",
"eslint": "^8.29.0",
"ts-node": "^10.9.1",
"typescript": "~4.5.5"
},
"main": "./dist/ee/apps/<%= name %>/src/service.js",
"files": [
"/dist"
]
}

43 changes: 43 additions & 0 deletions _templates/service/new/service.ejs.t
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
---
to: ee/apps/<%= name %>/src/service.ts
---
import type { Document } from 'mongodb';
import polka from 'polka';

import { api } from '../../../../apps/meteor/server/sdk/api';
import { broker } from '../../../../apps/meteor/ee/server/startup/broker';
import { Collections, getCollection, getConnection } from '../../../../apps/meteor/ee/server/services/mongo';
import { registerServiceModels } from '../../../../apps/meteor/ee/server/lib/registerServiceModels';

const PORT = process.env.PORT || 3034;

(async () => {
const db = await getConnection();

const trash = await getCollection<Document>(Collections.Trash);

registerServiceModels(db, trash);

api.setBroker(broker);

// need to import service after models are registered
const { <%= h.changeCase.pascalCase(name) %> } = await import('./<%= h.changeCase.pascalCase(name) %>');

api.registerService(new <%= h.changeCase.pascalCase(name) %>());

await api.start();

polka()
.get('/health', async function (_req, res) {
try {
await api.nodeList();
res.end('ok');
} catch (err) {
console.error('Service not healthy', err);

res.writeHead(500);
res.end('not healthy');
}
})
.listen(PORT);
})();
16 changes: 16 additions & 0 deletions _templates/service/new/servicesClass.ejs.t
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
---
to: ee/apps/<%= name %>/src/<%= h.changeCase.pascalCase(name) %>.ts
---
import { ServiceClass } from '../../../../apps/meteor/server/sdk/types/ServiceClass';

export class <%= h.changeCase.pascalCase(name) %> extends ServiceClass {
protected name = '<%= name %>';

constructor() {
super();

// your stuff
}

// more stuff
}
Loading

0 comments on commit 1d09a49

Please sign in to comment.