Fix Omni-webhooks retry mechanism going in infinite loop (#23394)

RocketChat · Oct 20, 2021 · 872cf28 · 872cf28
1 parent 9db0e22
commit 872cf28
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/app/livechat/server/lib/Livechat.js b/app/livechat/server/lib/Livechat.js
@@ -734,9 +734,9 @@ export const Livechat = {
 		} catch (e) {
 			Livechat.webhookLogger.error(`Response error on ${ 11 - attempts } try ->`, e);
 			// try 10 times after 10 seconds each
-			Livechat.webhookLogger.warn('Will try again in 10 seconds ...');
+			(attempts - 1) && Livechat.webhookLogger.warn('Will try again in 10 seconds ...');
 			setTimeout(Meteor.bindEnvironment(function() {
-				Livechat.sendRequest(postData, callback, attempts--);
+				Livechat.sendRequest(postData, callback, attempts - 1);
 			}), 10000);
 		}
 	},