fix review

app/lib/lib/roomTypes/direct.js

@@ -119,12 +119,8 @@ export class DirectMessageRoomType extends RoomTypeConfig {
 		}
 	}
 
-	allowMemberAction(room, action) {
-		switch (action) {
-			case RoomMemberActions.MUTE:
-			default:
-				return false;
-		}
+	allowMemberAction(/* room, action */) {
+		return false;
 	}
 
 	enableMembersListProfile() {

app/lib/lib/roomTypes/public.js

@@ -113,12 +113,8 @@ export class PublicRoomType extends RoomTypeConfig {
 		}
 	}
 
-	allowMemberAction(room, action) {
-		switch (action) {
-			case RoomMemberActions.MUTE:
-			default:
-				return true;
-		}
+	allowMemberAction(/* room, action */) {
+		return true;
 	}
 
 	getUiText(context) {

app/lib/server/methods/addUsersToRoom.js

@@ -30,7 +30,7 @@ Meteor.methods({
 		const userInRoom = subscription != null;
 
 		// Can't add to direct room ever
-		if (room.t === 'd') { // TODO CHANGE
+		if (room.t === 'd') {
 			throw new Meteor.Error('error-cant-invite-for-direct-room', 'Can\'t invite user to direct rooms', {
 				method: 'addUsersToRoom',
 			});

app/slashcommands-unarchiveroom/server/server.js

@@ -39,7 +39,7 @@ function Unarchive(command, params, item) {
 	}
 
 	// You can not archive direct messages.
-	if (!roomTypes.getConfig(room.t).allowRoomSettingChange(room, RoomMemberActions.ARCHIVE)) {
+	if (!roomTypes.getConfig(room.t).allowMemberAction(room, RoomMemberActions.ARCHIVE)) {
 		return;
 	}
 

server/methods/removeUserFromRoom.js

@@ -29,7 +29,7 @@ Meteor.methods({
 
 		const room = Rooms.findOneById(data.rid);
 
-		if (!room || !roomTypes.getConfig(room.t).allowRoomSettingChange(room, RoomMemberActions.REMOVE_USER)) {
+		if (!room || !roomTypes.getConfig(room.t).allowMemberAction(room, RoomMemberActions.REMOVE_USER)) {
 			throw new Meteor.Error('error-not-allowed', 'Not allowed', {
 				method: 'removeUserFromRoom',
 			});