use throw error in place of dispatching new toastmessage

RocketChat · Jan 16, 2023 · c58d09d · c58d09d
1 parent a624a08
commit c58d09d
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/apps/meteor/client/views/admin/apps/AppDetailsPage/tabs/AppReleases/AppReleases.tsx b/apps/meteor/client/views/admin/apps/AppDetailsPage/tabs/AppReleases/AppReleases.tsx
@@ -20,7 +20,7 @@ const AppReleases = ({ id }: { id: App['id'] }): ReactElement => {
 			const { apps } = await getVersions();
 
 			if (apps.length === 0) {
-				dispatchToastMessage({ type: 'error', message: t('No_results_found') });
+				throw new Error(t('No_results_found'));
 			}
 			return apps;
 		},

diff --git a/apps/meteor/client/views/admin/customSounds/AdminSoundsRoute.tsx b/apps/meteor/client/views/admin/customSounds/AdminSoundsRoute.tsx
@@ -54,7 +54,7 @@ const CustomSoundsRoute = (): ReactElement => {
 			const { sounds } = await getSounds(query);
 
 			if (sounds.length === 0) {
-				dispatchToastMessage({ type: 'error', message: t('No_results_found') });
+				throw new Error(t('No_results_found'));
 			}
 			return sounds;
 		},

diff --git a/apps/meteor/client/views/admin/customSounds/EditCustomSound.tsx b/apps/meteor/client/views/admin/customSounds/EditCustomSound.tsx
@@ -24,7 +24,7 @@ function EditCustomSound({ _id, onChange, ...props }: EditCustomSoundProps): Rea
 			const { sounds } = await getSounds({ query: JSON.stringify({ _id }) });
 
 			if (sounds.length === 0) {
-				dispatchToastMessage({ type: 'error', message: t('No_results_found') });
+				throw new Error(t('No_results_found'));
 			}
 			return sounds[0];
 		},

diff --git a/.../client/views/admin/permissions/UsersInRole/UsersInRoleTable/UsersInRoleTableWithData.tsx b/.../client/views/admin/permissions/UsersInRole/UsersInRoleTable/UsersInRoleTableWithData.tsx
@@ -45,7 +45,7 @@ const UsersInRoleTableWithData = ({
 			const { users } = await getUsersInRole(query);
 
 			if (users.length === 0) {
-				dispatchToastMessage({ type: 'error', message: t('No_results_found') });
+				throw new Error(t('No_results_found'));
 			}
 			return users;
 		},

diff --git a/apps/meteor/client/views/admin/rooms/RoomsTable.tsx b/apps/meteor/client/views/admin/rooms/RoomsTable.tsx
@@ -122,7 +122,7 @@ const RoomsTable = ({ reload }: { reload: MutableRefObject<() => void> }): React
 			const { rooms } = await getAdminRooms(params);
 
 			if (rooms.length === 0) {
-				dispatchToastMessage({ type: 'error', message: t('No_results_found') });
+				throw new Error(t('No_results_found'));
 			}
 			return rooms;
 		},