[IMPROVE] Split NOTIFICATIONS_SCHEDULE_DELAY into three separate vari…

…ables (#17669)

app/notification-queue/server/NotificationQueue.ts

@@ -8,7 +8,9 @@ import { PushNotification } from '../../push-notifications/server';
 const {
 	NOTIFICATIONS_WORKER_TIMEOUT = 2000,
 	NOTIFICATIONS_BATCH_SIZE = 100,
-	NOTIFICATIONS_SCHEDULE_DELAY = 120,
+	NOTIFICATIONS_SCHEDULE_DELAY_ONLINE = -1,
+	NOTIFICATIONS_SCHEDULE_DELAY_AWAY = 120,
+	NOTIFICATIONS_SCHEDULE_DELAY_OFFLINE = 0,
 } = process.env;
 
 class NotificationClass {
@@ -18,7 +20,11 @@ class NotificationClass {
 
 	private maxBatchSize = Number(NOTIFICATIONS_BATCH_SIZE);
 
-	private maxScheduleDelaySeconds = Number(NOTIFICATIONS_SCHEDULE_DELAY);
+	private maxScheduleDelaySecondsOnline = Number(NOTIFICATIONS_SCHEDULE_DELAY_ONLINE);
+
+	private maxScheduleDelaySecondsAway = Number(NOTIFICATIONS_SCHEDULE_DELAY_AWAY);
+
+	private maxScheduleDelaySecondsOffline = Number(NOTIFICATIONS_SCHEDULE_DELAY_OFFLINE);
 
 	initWorker(): void {
 		this.running = true;
@@ -109,19 +115,32 @@ class NotificationClass {
 			return;
 		}
 
-		const delay = this.maxScheduleDelaySeconds;
-
 		let schedule: Date | undefined;
 
 		if (user.statusConnection === 'online') {
+			if (this.maxScheduleDelaySecondsOnline === -1) {
+				return;
+			}
+
 			schedule = new Date();
-			schedule.setSeconds(schedule.getSeconds() + delay);
+			schedule.setSeconds(schedule.getSeconds() + this.maxScheduleDelaySecondsOnline);
 		} else if (user.statusConnection === 'away') {
+			if (this.maxScheduleDelaySecondsAway === -1) {
+				return;
+			}
+
 			const elapsedSeconds = Math.floor((Date.now() - user._updatedAt) / 1000);
-			if (elapsedSeconds < delay) {
+			if (elapsedSeconds < this.maxScheduleDelaySecondsAway) {
 				schedule = new Date();
-				schedule.setSeconds(schedule.getSeconds() + delay - elapsedSeconds);
+				schedule.setSeconds(schedule.getSeconds() + this.maxScheduleDelaySecondsAway - elapsedSeconds);
+			}
+		} else if (user.statusConnection === 'offline') {
+			if (this.maxScheduleDelaySecondsOffline === -1) {
+				return;
 			}
+
+			schedule = new Date();
+			schedule.setSeconds(schedule.getSeconds() + this.maxScheduleDelaySecondsOffline);
 		}
 
 		await NotificationQueue.insertOne({