Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[snap] add option to mount media #13391

Closed
geekgonecrazy opened this issue Feb 6, 2019 · 4 comments · Fixed by #13591
Closed

[snap] add option to mount media #13391

geekgonecrazy opened this issue Feb 6, 2019 · 4 comments · Fixed by #13591
Labels
contrib: easy deploy: snaps type: improvement

Comments

@geekgonecrazy
Copy link
Contributor

geekgonecrazy commented Feb 6, 2019 •
edited
Loading

Allow media plug so snaps can write to /media
Should be as easy as adding the removable-media plug: https://github.com/nextcloud/nextcloud-snap/blob/master/snap/snapcraft.yaml#L81 to our rocketchat-server part.

Then need to add something like this to the docs to tell people how to do it: https://github.com/nextcloud/nextcloud-snap/blob/master/README.md#removable-media
@geekgonecrazy geekgonecrazy mentioned this issue Feb 6, 2019
Closed
@knrt10
Copy link
Contributor

knrt10 commented Mar 1, 2019

I would like to fix this

knrt10 added a commit to knrt10/Rocket.Chat that referenced this issue Mar 1, 2019
@knrt10
Fixes RocketChat#13391
8e684ae
@knrt10 knrt10 mentioned this issue Mar 1, 2019
Merged
knrt10 added a commit to knrt10/Rocket.Chat that referenced this issue Mar 1, 2019
@knrt10
Fixes RocketChat#13391
07a8297
knrt10 added a commit to knrt10/Rocket.Chat that referenced this issue Mar 13, 2019
@knrt10
Fixes RocketChat#13391
6b61e69
@sp2703
Copy link

sp2703 commented Nov 12, 2019

I would like to contribute on this issue. Any points to refer to?

@geekgonecrazy
Copy link
Contributor Author

This has been added for a while now: https://rocket.chat/docs/installation/manual-installation/ubuntu/snaps/#how-do-i-add-option-to-mount-media

@Skinner927
Copy link

Skinner927 commented Feb 18, 2020 •
edited
Loading

@geekgonecrazy I don't think it was ever merged?? #13591
It's not working on latest snap (2.4.9 rev 1422) anyways.

geekgonecrazy pushed a commit that referenced this issue Feb 18, 2020
@knrt10
Fixes #13391 (#13591)
35d7029
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contrib: easy deploy: snaps type: improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add option to mount media on snap knrt10/Rocket.Chat
4 participants
@geekgonecrazy @Skinner927 @knrt10 @sp2703