Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login errors in 3.1.0 #17259

Closed
dusatvoj opened this issue Apr 11, 2020 · 24 comments · Fixed by #17302
Closed

Login errors in 3.1.0 #17259

dusatvoj opened this issue Apr 11, 2020 · 24 comments · Fixed by #17302

Comments

@dusatvoj
Copy link

Description:

After upgrade to v3.1.0:

  • I can't login to RC from Android App (v4.5.2)
  • I lose login every time I close desktop app / firefox tab

Steps to reproduce:

  1. Open desktop app / web browser
  2. Login to server
  3. Close web browser RC tab / dekstop app
  4. Reopen app / browser tab

Expected behavior:

Login remains

Actual behavior:

After loading page is shown login page and error Invalid User

Server Setup Information:

  • Version of Rocket.Chat Server: 3.1.0
  • Operating System: Debian 9
  • Deployment Method: tar
  • Number of Running Instances: 1
  • DB Replicaset Oplog: yes
  • NodeJS Version: 12.14.0
  • MongoDB Version: 3.6.17

Client Setup Information

  • Desktop App or Browser Version: App 2.17.9-1, Browser firefox 75.0-1
  • Operating System: Arch linux

Relevant logs:

Server

Nothing 😕

Browser

[Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIFaviconService.replaceFaviconDataFromDataURL]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: resource:///modules/PlacesUIUtils.jsm :: loadFavicon :: line 209"  data: no] PlacesUIUtils.jsm:209:28
    loadFavicon resource:///modules/PlacesUIUtils.jsm:209
    loadFavicon resource:///modules/PlacesUIUtils.jsm:362
    setIconFromLink resource:///actors/LinkHandlerParent.jsm:154
    receiveMessage resource:///actors/LinkHandlerParent.jsm:71
TypeError: window is null 2 WebRequestContent.js:143:7
NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIInterfaceRequestor.getInterface] network-response-listener.js:84
Sync encountered an error - see about:sync-log for the log file. policies.js:1008
    resetFileLog resource://services-sync/policies.js:1008
    InterpretGeneratorResume self-hosted:1156
    AsyncFunctionNext self-hosted:695
@DJeremyy
Copy link

DJeremyy commented Apr 11, 2020

Since the update to 3.1.0 made yesterday, I have the same errors when connecting to the web application. It disconnects after closing the tab with Invalid user.

iOS (4.6.3) and Android (4.5.2) application no longer works. Unable to connect when I reset the app.

@danielnachtrub
Copy link

We've got the same issue here. Started with an image upgrade.

Rocketchat is running in a docker-environment with nginx as reverse-proxy and LDAP backend. Docker is using the official image from hub.

  • Client application running on Windows can login but loses session upon restart or server reload. Same on macOS.
  • Running in browser rocketchat is working but after reloading the page the same error occurs.
  • iOS app cannot login at all.

@Shaverdoff
Copy link

Shaverdoff commented Apr 11, 2020

guys - option on Accoutn settigns - Forget User Session on Window Close is enabled?

@danielnachtrub
Copy link

guys - option on Accoutn settigns - Forget User Session on Window Close is enabled?

Not enabled here.

@dusatvoj
Copy link
Author

guys - option on Accoutn settigns - Forget User Session on Window Close is enabled?

Disabled

@Shaverdoff
Copy link

Shaverdoff commented Apr 11, 2020 via email

@DJeremyy
Copy link

guys - option on Accoutn settigns - Forget User Session on Window Close is enabled?

Disabled for me

@danielnachtrub
Copy link

danielnachtrub commented Apr 11, 2020

Rc confgired with ldap? Отправлено с iPhone

11 апр. 2020 г., в 16:59, Daniel Nachtrub @.***> написал(а):  guys - option on Accoutn settigns - Forget User Session on Window Close is enabled? Not enabled here. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

We're using LDAP authentication.

@DJeremyy
Copy link

Rc confgired with ldap? Отправлено с iPhone

11 апр. 2020 г., в 16:59, Daniel Nachtrub @.***> написал(а):  guys - option on Accoutn settigns - Forget User Session on Window Close is enabled? Not enabled here. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

Yes, I'm use LDAP sync for accounts and authentication.

@Shaverdoff
Copy link

Shaverdoff commented Apr 11, 2020 via email

@dusatvoj
Copy link
Author

I have LDAP enabled

@danielnachtrub
Copy link

Checking the console output from devtools on client it states:

Error logging in with token: Error: Login forbidden [403]
E2E -> Stop Client

@danielnachtrub
Copy link

I found a workaround in our environment:
By enabling Login Fallback the issues do not arise anymore.

Seems that there's an issue to recognize existing sessions here. Perhaps request is cancelled when login fallback is disabled and therefore even existing sessions using tokens can't be validated.

@DJeremyy
Copy link

I found a workaround in our environment:
By enabling Login Fallback the issues do not arise anymore.

This is also the case for me @danielnachtrub, activating 'Login Fallback' in the LDAP section no longer causes connection problems on Android and iOS. I no longer have 'Invalid user' when I close the tab and open it again.

@Shaverdoff
Copy link

Shaverdoff commented Apr 12, 2020 via email

@pierre-lehnen-rc
Copy link
Contributor

Did everyone who had this problem uses LDAP?
If so, this may have been caused by #16949

@nebulade
Copy link

We at Cloudron hit this as well now in our package tests. Those instances also use LDAP.

@DJeremyy
Copy link

Did everyone who had this problem uses LDAP?
If so, this may have been caused by #16949

For me @pierre-lehnen-rc, I use LDAP. it seems to me that this is the case for everyone here.

@spanchy
Copy link

spanchy commented Apr 13, 2020

I have same problem. LDAP auth enabled.

@tiredofit
Copy link

Same problem with LDAP, Also cannot use SAML.

@photoninger
Copy link

photoninger commented Apr 22, 2020

Upgraded from 3.0.12 to 3.1.1, now both mobile apps (ios and android) crash on login with ldap users.
ldap fallback is enabled (was all the time)

Edit:
only the apps with version 4.6.x crash, version 4.5.1 works. Opened an issue for the app:
RocketChat/Rocket.Chat.ReactNative#2054

@sampaiodiego
Copy link
Member

the app just crash? no additional info? @diegolmello how can we track down what is happening in this case?

@diegolmello
Copy link
Member

@sampaiodiego There's a fix on the way here

@tiredofit
Copy link

I am seeing it as well and referenced in #17318 where the Syncing process has failed thus locking out my users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.