Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting ADMIN_PASS shows password in log #4806

Closed
asthomasdk opened this issue Nov 1, 2016 · 1 comment · Fixed by #15307
Closed

Setting ADMIN_PASS shows password in log #4806

asthomasdk opened this issue Nov 1, 2016 · 1 comment · Fixed by #15307
Assignees
Labels

Comments

@asthomasdk
Copy link

Your Rocket.Chat version: 0.43.0, 0.45.0

When a rocket instance starts up - if the ADMIN_PASS environment variable is set - this password is displayed in the log. it is ok to display that the password is being set - but to actually write it to the log is not a good idea.

Although this password can easily be changed, it could be a security problem.

I would suggest just logging that the admin user password is being set - without showing what it is.

@andypost
Copy link

andypost commented Feb 6, 2017

Looks a duplicate of #3069

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants