Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to not use ™️ icon for ™ character #7386

Closed
drasbeck opened this issue Jul 2, 2017 · 4 comments · Fixed by RocketChat/fuselage#500
Closed

Add option to not use ™️ icon for ™ character #7386

drasbeck opened this issue Jul 2, 2017 · 4 comments · Fixed by RocketChat/fuselage#500
Assignees
@ggazzo
Labels
feat: message stat: triaged Issue reviewed and properly tagged type: improvement ui/ux

Comments

@drasbeck
Copy link

drasbeck commented Jul 2, 2017

Rocket.Chat Version: 0.56.0

The icon Rocket.Chat exchanges the ™ character for is a little obnoxious, and it would be great with the option to not use it.

What I see:
what_i_see

What I would like to see:
what_i_would_like_to_see
@geekgonecrazy
Copy link
Contributor

Does it do this with any other characters? Or is it only the TM character?

@drasbeck
Copy link
Author

drasbeck commented Jul 3, 2017

I have not experienced this with any other characters. It simply exchanges ™ for :tm: as far as I can see.

@drasbeck drasbeck changed the title Add option to not use TM icon for ™ Add option to not use ™️ icon for ™ character Jul 3, 2017
@geekgonecrazy
Copy link
Contributor

Ah it's the TM emoji! Makes sense now! I thought this was happening with the TM Unicode character

@2xB
Copy link

2xB commented Apr 19, 2021 •
edited
Loading

I think there is confusion™ because this is actually a bug: If you enter the trademark symbol ™, U+2122 - not the emoji variant ™️ U+2122-FE0F (!) -, it is exchanged with the emoji version. This does not happen for e.g. copyright (©, U+00A9) or any other character I tested that is listed in https://github.com/RocketChat/Rocket.Chat/blob/157b882d38b34b7b79dea527316554fe33f70891/app/emoji-emojione/lib/rocketchat.js , and it also quite frankly doesn't make any sense.

2xB added a commit to 2xB/Rocket.Chat that referenced this issue Apr 27, 2021
@2xB
Escape trademark sign
7593810 
Before this, the trademark character (™) was automatically replaced with ™️ ,
showing the trademark symbol in a totally unfitting size for most contexts.
This commit avoids that by replacing the sign with its HTML escaped version
(as can be seen in `Rocket.Chat/client/lib/renderMessageBody.ts`).

Fixes RocketChat#7386.
2xB added a commit to 2xB/Rocket.Chat that referenced this issue Apr 27, 2021
@2xB
Escape trademark sign
47fe27a 
Before this, the trademark character (™) was automatically replaced with ™️ ,
showing the trademark symbol in a totally unfitting size for most contexts.
This commit avoids that by replacing the sign with its HTML escaped version
(as can be seen in `Rocket.Chat/client/lib/renderMessageBody.ts`).

Fixes RocketChat#7386.
2xB added a commit to 2xB/Rocket.Chat that referenced this issue Apr 27, 2021
@2xB
Escape trademark sign
75b8615 
Before this, the trademark character (™) was automatically replaced with ™️ ,
showing the trademark symbol in a totally unfitting size for most contexts.
This commit avoids that by replacing the sign with its HTML escaped version
(as can be seen in `Rocket.Chat/client/lib/renderMessageBody.ts`).

Fixes RocketChat#7386.
2xB added a commit to 2xB/Rocket.Chat that referenced this issue Apr 27, 2021
@2xB
Escape trademark sign
c270306 
Before this, the trademark character (™) was automatically replaced with ™️ ,
showing the trademark symbol in a totally unfitting size for most contexts.
This commit avoids that by replacing the sign with its HTML escaped version
before further replacements e.g. via emojione are applied
(as can be seen in `Rocket.Chat/client/lib/renderMessageBody.ts`).

This is identical to how e.g. the registered trademark sign is currently handled.

Fixes RocketChat#7386.
@2xB 2xB mentioned this issue Apr 27, 2021
Closed
@2xB 2xB mentioned this issue Jul 15, 2021
Merged
8 tasks
@tassoevan tassoevan added stat: triaged Issue reviewed and properly tagged and removed Triaged labels Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ggazzo ggazzo

Labels
feat: message stat: triaged Issue reviewed and properly tagged type: improvement ui/ux
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Escape trademark sign 2xB/Rocket.Chat.Fuselage
[FIX] Escape trademark sign 2xB/Rocket.Chat
6 participants
@geekgonecrazy @tassoevan @theorenck @ggazzo @drasbeck @2xB