-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Dropdown elements were using old styles #10482
Merged
rodrigok
merged 4 commits into
RocketChat:develop
from
kaiiiiiiiii:fix_selector_element_type_for_dropdowns
Apr 19, 2018
Merged
[FIX] Dropdown elements were using old styles #10482
rodrigok
merged 4 commits into
RocketChat:develop
from
kaiiiiiiiii:fix_selector_element_type_for_dropdowns
Apr 19, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaiiiiiiiii
changed the title
[FIX] Changes all dropdwon element types
[FIX] Changes all dropdown element types
Apr 17, 2018
kaiiiiiiiii
changed the title
[FIX] Changes all dropdown element types
[FIX] Change dropdown element types
Apr 17, 2018
@kaiiiiiiiii can you add this arrow icon like we did on the RocketChat Apps admin panel? Thank you! 👍 |
@karlprieb Done :) |
Thank you @kaiiiiiiiii :) Can you add a screenshot about the cut off at the bottom that all select elements have? |
@kaiiiiiiiii you can put |
Done that as well, mate :) |
karlprieb
approved these changes
Apr 19, 2018
rodrigok
changed the title
[FIX] Change dropdown element types
[FIX] Dropdown elements were using old styles
Apr 19, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes my promise to @karlprieb.
This PR changes all dropdown element types from rc-input__element to rc-select__element.
Two more things:
Before (User UI):
After (User UI):
Before (Admin UI):
After (Admin UI):