Regression: Updating an App on multi-instance servers wasn't working #10611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampaiodiego
requested changes
Apr 27, 2018
| @@ -70,7 +70,7 @@ RocketChat.API = { | |||
|
|
|||
| return new Promise(function _jqueryFormDataPromise(resolve, reject) { | |||
| jQuery.ajax({ | |||
| url: `${ Meteor.absoluteUrl() }api/${ endpoint }${ query }`, | |||
| url: `${ window.location.origin }/api/${ endpoint }${ query }`, | |||
There was a problem hiding this comment.
why not use?
url: Meteor.absoluteUrl(`/api/${ endpoint }${ query }`),
There was a problem hiding this comment.
Because the Meteor.absoluteUrl uses the configured url and when you are testing against a specific instance, it calls another instance. We currently don't use these utilities, so we can improve them later.
There was a problem hiding this comment.
oh.. we don't take care of a case like this in anywhere.. we always assume all instances are at same domain.
| @@ -53,6 +54,15 @@ export class AppServerListener { | |||
| this.clientStreamer.emit(AppEvents.APP_SETTING_UPDATED, { appId }); | |||
| } | |||
|
|
|||
| async onAppUpdated(appId) { | |||
| this.recieved.set(`${ AppEvents.APP_UPDATED }_${ appId }`, { appId, when: new Date() }); | |||
There was a problem hiding this comment.
typo: recieved -> received
sampaiodiego
approved these changes
Apr 27, 2018
|
@rodrigok why did this not make it into the official v64 release? |
|
@graywolf336 IDK, maybe it wasn't pointing to the milestone and project? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now it is. :)