Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Regression on 0.64.0 was freezing the application when posting some URLs #10627

Merged
merged 2 commits into from
May 3, 2018

Conversation

rodrigok
Copy link
Member

Original PR was #10496

closes #10616

@rodrigok rodrigok added this to the 0.64.1 milestone Apr 30, 2018
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-10627 April 30, 2018 21:22 Inactive
@rodrigok rodrigok force-pushed the hotfix/url-parse-freeze branch from f6ba0e5 to 0d07699 Compare April 30, 2018 22:19
@rodrigok rodrigok temporarily deployed to rocket-chat-pr-10627 April 30, 2018 22:19 Inactive
@kaos
Copy link

kaos commented May 2, 2018

We had issues that this PR will most likely resolve. As we patched the code in sendMessage to not parse any urls in messages to avoid a regexp hanging when parsing a URL such as this: https://docs.mongodb.com/manual/reference/configuration-options/#storage.wiredTiger.engineConfig.cacheSizeGB

The offending regexp in sendMessage.js was:

const ignoredUrls = message.msg.match(/(?:(?:\`{1,3})(?:[\n\r]*?.*?)*?)(([A-Za-z]{3,9}):\/\/([-;:&=\+\$,\w]+@{1})?([-A-Za-z0-9\.]+)+:?(\d+)?((\/[-\+=!:~%\/\.@\,\(\)\w]*)?\??([-\+=&!:;%@\/\.\,\w]+)?(?:#([^\s\)]+))?)?)(?:(?:[\n\r]*.*?)*?(?:\`{1,3}))/gm);

Looking forward to a patch release asap :)

@neurolabs
Copy link

Since this seems to affect a lot of installations, and a downgrade is not easily feasible/possible without data loss due to migrations, a quick release would be highly appreciated. Is the review by @gdelavald mandatory?

Thanks for all the hard work.

@rodrigok rodrigok merged commit 73e8ba3 into develop May 3, 2018
@rodrigok rodrigok deleted the hotfix/url-parse-freeze branch May 3, 2018 12:01
@rodrigok rodrigok mentioned this pull request May 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RC instances get stuck after a while after update to 0.64.0
5 participants