-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMPROVE] User mentions #11001
[IMPROVE] User mentions #11001
Conversation
@@ -598,6 +598,10 @@ input:-webkit-autofill { | |||
} | |||
|
|||
.mention-link { | |||
&:not(.mention-link-me):not(.mention-link-all) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@karlprieb @ggazzo do we need this? or till the more specific selector class="mention-link mention-link-me" already overwrite the background colour?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, the default now puts light-green text on a light-blue background. Why would anyone think that is an improvement to what it has looked like before? We fixed that by using this custom CSS for now, but please fix this bad default... .message .mention-link {
background-color: @rc-color-button-primary;
color : #fff;
}
.message .mention-link:hover {
color: #fff;
} |
@yahesh Do you have any custom CSS or colors? It seems to look OK on open.rocket.chat...? |
@vynmera We use colour-blindness improved status colours, but as far as I can see, none of these should modify /* Improve colours for colour-blindness */
:root {
--status-away: #6db6ff !important;
--status-busy: #FF0000 !important;
--status-invisible: #004949 !important;
--status-invisible-sidebar: #004949 !important;
--status-offline: #004949 !important;
--status-online: #24ff24 !important;
} |
We've looked into this some more and as it seems, the corresponding configuration has moved to "Old Colors (minor)" some time ago and is difficult to follow as |
We've reverted to the default colour scheme (except for the status colours) to solve this on our side. |
Related to #10968
It makes the mentions look nicer, and stand out from normal links (otherwise, one could change their name to an URL and be invisible)
Not sure whether it's a [FIX] or a [NEW], but it's small so I'll pick the former.
Old
![2018-06-04_22-25-21](https://user-images.githubusercontent.com/39674991/40940034-c90d62ec-6846-11e8-94bf-e861b8d0ed0a.png)
New
![2018-06-04_22-24-44](https://user-images.githubusercontent.com/39674991/40940050-d05b4e88-6846-11e8-9937-7f8a6a63e89e.png)