-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NEW] Add prometheus port config #11115
[NEW] Add prometheus port config #11115
Conversation
[FIX] i18n - add semantic markup
[FIX] Fix spelling of "collaborative"
|
My only problem is this now becomes a breaking change. Because it was released with 9100 already, so if we change the default then when people upgrade it's broken |
I'm OK with not setting a default value of |
I've changed the default value of |
Can someone please take a look at this change? |
[NEW] Allow the Prometheus port to be configurable
Closes #11114
This also picks a default port number that doesn't conflict with existing allocations from https://github.com/prometheus/prometheus/wiki/Default-port-allocations. Per the recommendation, I use the
9451
port, which is available after the one allocated to Habitat Exporter