Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve image oembed #1170

Merged
merged 3 commits into from
Oct 19, 2015
Merged

Improve image oembed #1170

merged 3 commits into from
Oct 19, 2015

Conversation

rodrigok
Copy link
Member

Before
captura de tela 2015-10-19 as 21 07 23

After
captura de tela 2015-10-19 as 21 06 46

@sampaiodiego
Copy link
Member

I don't think it is a good idea to round the image corners

@rodrigok
Copy link
Member Author

Why?

@sampaiodiego
Copy link
Member

you are losing image data.

engelgabriel added a commit that referenced this pull request Oct 19, 2015
@engelgabriel engelgabriel merged commit c235f9c into master Oct 19, 2015
@rodrigok rodrigok deleted the improvement/image-oembed branch October 19, 2015 19:32
@geekgonecrazy
Copy link
Contributor

@sampaiodiego are we loosing that much? Enough to actually be noticed or missed?

@geekgonecrazy
Copy link
Contributor

Does this also solve #1138 ?

@sampaiodiego
Copy link
Member

Well, not so much. Its more like a preference :)

Em seg, 19 de out de 2015 22:27, Aaron Ogle notifications@github.com
escreveu:

Does this also solve #1138
#1138 ?


Reply to this email directly or view it on GitHub
#1170 (comment)
.

.Diego Sampaio

@stefanlegg
Copy link

Was there anything particularly wrong with my pr (#1167)?
If so, constructive criticism would be awesome.

@geekgonecrazy
Copy link
Contributor

@stefanlegg I didn't see anything wrong with your PR. I'm trying to see if it solved both problems yours solved if so then the changes are now in master. If not then we need to find out what we can do to also get your changes in and fix #1138

@stefanlegg
Copy link

@geekgonecrazy Gotcha, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants