-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve image oembed #1170
Improve image oembed #1170
Conversation
I don't think it is a good idea to round the image corners |
Why? |
you are losing image data. |
@sampaiodiego are we loosing that much? Enough to actually be noticed or missed? |
Does this also solve #1138 ? |
Well, not so much. Its more like a preference :) Em seg, 19 de out de 2015 22:27, Aaron Ogle notifications@github.com
|
Was there anything particularly wrong with my pr (#1167)? |
@stefanlegg I didn't see anything wrong with your PR. I'm trying to see if it solved both problems yours solved if so then the changes are now in master. If not then we need to find out what we can do to also get your changes in and fix #1138 |
@geekgonecrazy Gotcha, thanks! |
Before
![captura de tela 2015-10-19 as 21 07 23](https://cloud.githubusercontent.com/assets/234261/10588294/a737c53a-76a5-11e5-8cda-7fd022ef04ae.png)
After
![captura de tela 2015-10-19 as 21 06 46](https://cloud.githubusercontent.com/assets/234261/10588295/a74d8186-76a5-11e5-9967-999523123d1a.png)