Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Spotify embed link opens in same tab #13637

Merged
merged 3 commits into from
May 30, 2020
Merged

[FIX] Spotify embed link opens in same tab #13637

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7b9b5f2
[FIX] Embed link opens in same tab
bhardwajaditya Mar 7, 2019
ef004a5
Merge branch 'develop' of https://github.com/RocketChat/Rocket.Chat i…
bhardwajaditya Mar 16, 2019
0ad7ed5
Merge branch 'develop' into issue13581
rodrigok May 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/spotify/lib/client/oembedSpotifyWidget.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
<blockquote class="message-oembed background-transparent-darker-before">
<a href="https://www.spotify.com" rel="noopener noreferrer" style="color: #9e9ea6">Spotify</a><br/>
{{#if match meta.ogAudio "spotify:artist:\\S+"}}
<a rel="noopener noreferrer" href="{{url}}">{{{meta.ogTitle}}}</a>
<a rel="noopener noreferrer" href="{{url}}" target="_blank">{{{meta.ogTitle}}}</a>
{{else}}
<a rel="noopener noreferrer" href="{{url}}">{{{replace meta.ogDescription ", an? (?:song|album) by (.+?) on Spotify" " - $1" regex=true}}}</a>
<a rel="noopener noreferrer" href="{{url}}" target="_blank">{{{replace meta.ogDescription ", an? (?:song|album) by (.+?) on Spotify" " - $1" regex=true}}}</a>
{{/if}}
{{> collapseArrow collapsedMedia=collapsedMediaVar}} <br>
{{#unless collapsed}}
Expand Down