[NEW] Custom User Status #13933

Hudell · 2019-03-28T14:23:24Z

This PR merges together the implementations of custom user status on two different PRs: #12710 (by @wreiske ) and #9353 (by me)

It adds the ability for admins to register additional user status and also for users to type in any custom message as their current status.

…to custom_user_status

…e target was an input

wreiske · 2019-06-19T17:36:56Z

app/ui/client/components/header/headerRoom.js

@@ -120,7 +119,7 @@ Template.headerRoom.helpers({
 		const statusText = roomTypes.getUserStatusText(roomData.t, this._id);

 		if (s.trim(statusText)) {
-			return emojione.render(s.escapeHTML(statusText));
+			return statusText;


Is there a plan to add back support for rendering emojis in the status messages?

Yes, I just removed it now to make sure the PR is ready for the version cut, but I'll implement the new emoji renderer once I'm done with some other work I'm busy with.

wreiske · 2019-06-21T21:59:40Z

🚀

* Service Account broadcast room callback added * Service Account Callback completed * CLI errors fixed * [NEW] Service Account one-tap login complete * Callbacks modified * Service Accounts directory tab added * [NEW] Service Accounts Login method * Typo fixed * CLI errors fixed * CLI errors fixed * [FIX] Anonymous chat read (RocketChat#14717) * Prevent errors when allowing anonymous read * getSingleMessage for anonymous users * Fix register user when allow read and write anonymous is enabled * Fix anonymous with sidebar extended as default Co-authored-by: ubergeekzone <ubergeekzone@gmail.com> * [New] Service Account directory feature * CLI errors fixed * UsernameExists meteor method fixed * Sync commit * [NEW] Add loading animation to webdav file picker (RocketChat#14759) * [NEW] Service Account subscription method added * [NEW] Service account subscription sidenav type * changed mongo version for snap from 3.2.7 to 3.4.20 (RocketChat#14838) * add _hidden for messages loaded by thread (RocketChat#14837) * Regression: thread loading parent msg if is not loaded (RocketChat#14839) * [IMPROVE] Layout of livechat manager pages to new style (RocketChat#13900) * [FIX] Removes E2E action button, icon and banner when E2E is disabled. (RocketChat#14810) * [IMPROVE] Adds link to download generated user data file (RocketChat#14175) * [FIX] Error when using Download My Data or Export My Data (RocketChat#14645) * [NEW] Custom User Status (RocketChat#13933) Co-Authored-By: Tasso Evangelista <tasso@tassoevan.me> Co-Authored-By: Guilherme Gazzo <guilhermegazzo@gmail.com> Co-Authored-By: wreiske <wreiske@mieweb.com> * Allow debugging of cached collections by name (RocketChat#14859) * Regression: Allow debugging of cached collections by name (RocketChat#14862) * Regression: Fix desktop notifications not being sent (RocketChat#14860) * Broadcast Room name change handled * Lint errors fixed * getLoginToken method refactored * Console statements removed * Sidebar header permission modified * Merge branch service-accounts * Added service account directory search translation key * Subscribers count added * [NEW] Service Account sidenav type * Synced with base branch

* [FIX] Load messages after disconnect and message box scroll missing (RocketChat#14668) * Removing unnecesary federation configs (RocketChat#14674) * [FIX] SAML login error. (RocketChat#14686) * Bump version to 1.1.1 * Service Account broadcast room callback added * Service Account Callback completed * CLI errors fixed * [NEW] Service Account one-tap login complete * Callbacks modified * Service Accounts directory tab added * [NEW] Service Accounts Login method * Typo fixed * CLI errors fixed * CLI errors fixed * [FIX] Anonymous chat read (RocketChat#14717) * Prevent errors when allowing anonymous read * getSingleMessage for anonymous users * Fix register user when allow read and write anonymous is enabled * Fix anonymous with sidebar extended as default Co-authored-by: ubergeekzone <ubergeekzone@gmail.com> * [FIX] User Real Name being erased when not modified (RocketChat#14711) * [FIX] User status information on User Info panel (RocketChat#14763) * [FIX] Anonymous chat read (RocketChat#14717) * Prevent errors when allowing anonymous read * getSingleMessage for anonymous users * Fix register user when allow read and write anonymous is enabled * Fix anonymous with sidebar extended as default Co-authored-by: ubergeekzone <ubergeekzone@gmail.com> * Bump version to 1.1.2 * [New] Service Account directory feature * CLI errors fixed * UsernameExists meteor method fixed * Sync commit * [NEW] Add loading animation to webdav file picker (RocketChat#14759) * [NEW] Service Account subscription method added * changed mongo version for snap from 3.2.7 to 3.4.20 (RocketChat#14838) * add _hidden for messages loaded by thread (RocketChat#14837) * Regression: thread loading parent msg if is not loaded (RocketChat#14839) * [IMPROVE] Layout of livechat manager pages to new style (RocketChat#13900) * [FIX] Removes E2E action button, icon and banner when E2E is disabled. (RocketChat#14810) * add _hidden for messages loaded by thread (RocketChat#14837) * Regression: thread loading parent msg if is not loaded (RocketChat#14839) * Bump version to 1.1.3 * [IMPROVE] Adds link to download generated user data file (RocketChat#14175) * [FIX] Error when using Download My Data or Export My Data (RocketChat#14645) * [NEW] Custom User Status (RocketChat#13933) Co-Authored-By: Tasso Evangelista <tasso@tassoevan.me> Co-Authored-By: Guilherme Gazzo <guilhermegazzo@gmail.com> Co-Authored-By: wreiske <wreiske@mieweb.com> * Bump version to 1.2.0-rc.0 * Allow debugging of cached collections by name (RocketChat#14859) * Regression: Allow debugging of cached collections by name (RocketChat#14862) * Regression: Fix desktop notifications not being sent (RocketChat#14860) * Broadcast Room name change handled * Lint errors fixed * getLoginToken method refactored * Console statements removed * Sidebar header permission modified * Merge branch service-accounts * Added service account directory search translation key * Subscribers count added * [FIX] Custom status fixes (RocketChat#14853) * Fixes for status message text presence issues Added statusText to several api endpoints Changed statusMessage to statusText since that is what it is called everywhere * Fixed slash command for changing status * Fixed the "name is required" issue * Make sure the status is set blank if selecting a default status... we don't want an "online" status when someone is actually offline! * Fixes display of custom status on the room header * Changed the header of DM rooms to query the server for the user status text when it is not found on the internal collection * Changed Custom Status methods to check if the user is logged in * Improved code readability * Fix getting status list before logging in * Bump version to 1.2.0-rc.1 * [FIX] LinkedIn OAuth login (RocketChat#14887) * [NEW] Show App bundles and its apps (RocketChat#14886) * Bump version to 1.2.0-rc.2 * Bump version to 1.2.0 * Bump version to 1.3.0-develop * [FIX] Not showing local app on App Details (RocketChat#14894) * Unread counter added in popver * Get linked service account method added

* [FIX] Load messages after disconnect and message box scroll missing (RocketChat#14668) * Removing unnecesary federation configs (RocketChat#14674) * [FIX] SAML login error. (RocketChat#14686) * Bump version to 1.1.1 * Service Account broadcast room callback added * Service Account Callback completed * CLI errors fixed * [NEW] Service Account one-tap login complete * Callbacks modified * Service Accounts directory tab added * [NEW] Service Accounts Login method * Typo fixed * CLI errors fixed * CLI errors fixed * [FIX] Anonymous chat read (RocketChat#14717) * Prevent errors when allowing anonymous read * getSingleMessage for anonymous users * Fix register user when allow read and write anonymous is enabled * Fix anonymous with sidebar extended as default Co-authored-by: ubergeekzone <ubergeekzone@gmail.com> * [FIX] User Real Name being erased when not modified (RocketChat#14711) * [FIX] User status information on User Info panel (RocketChat#14763) * [FIX] Anonymous chat read (RocketChat#14717) * Prevent errors when allowing anonymous read * getSingleMessage for anonymous users * Fix register user when allow read and write anonymous is enabled * Fix anonymous with sidebar extended as default Co-authored-by: ubergeekzone <ubergeekzone@gmail.com> * Bump version to 1.1.2 * [New] Service Account directory feature * CLI errors fixed * UsernameExists meteor method fixed * Sync commit * [NEW] Add loading animation to webdav file picker (RocketChat#14759) * [NEW] Service Account subscription method added * changed mongo version for snap from 3.2.7 to 3.4.20 (RocketChat#14838) * add _hidden for messages loaded by thread (RocketChat#14837) * Regression: thread loading parent msg if is not loaded (RocketChat#14839) * [IMPROVE] Layout of livechat manager pages to new style (RocketChat#13900) * [FIX] Removes E2E action button, icon and banner when E2E is disabled. (RocketChat#14810) * add _hidden for messages loaded by thread (RocketChat#14837) * Regression: thread loading parent msg if is not loaded (RocketChat#14839) * Bump version to 1.1.3 * [IMPROVE] Adds link to download generated user data file (RocketChat#14175) * [FIX] Error when using Download My Data or Export My Data (RocketChat#14645) * [NEW] Custom User Status (RocketChat#13933) Co-Authored-By: Tasso Evangelista <tasso@tassoevan.me> Co-Authored-By: Guilherme Gazzo <guilhermegazzo@gmail.com> Co-Authored-By: wreiske <wreiske@mieweb.com> * Bump version to 1.2.0-rc.0 * Allow debugging of cached collections by name (RocketChat#14859) * Regression: Allow debugging of cached collections by name (RocketChat#14862) * Regression: Fix desktop notifications not being sent (RocketChat#14860) * Broadcast Room name change handled * Lint errors fixed * getLoginToken method refactored * Console statements removed * Sidebar header permission modified * Merge branch service-accounts * Added service account directory search translation key * Subscribers count added * [FIX] Custom status fixes (RocketChat#14853) * Fixes for status message text presence issues Added statusText to several api endpoints Changed statusMessage to statusText since that is what it is called everywhere * Fixed slash command for changing status * Fixed the "name is required" issue * Make sure the status is set blank if selecting a default status... we don't want an "online" status when someone is actually offline! * Fixes display of custom status on the room header * Changed the header of DM rooms to query the server for the user status text when it is not found on the internal collection * Changed Custom Status methods to check if the user is logged in * Improved code readability * Fix getting status list before logging in * Bump version to 1.2.0-rc.1 * [FIX] LinkedIn OAuth login (RocketChat#14887) * [NEW] Show App bundles and its apps (RocketChat#14886) * Bump version to 1.2.0-rc.2 * Bump version to 1.2.0 * Bump version to 1.3.0-develop * [FIX] Not showing local app on App Details (RocketChat#14894) * Unread counter added in popver * Get linked service account method added * get cloud generated public key for marketplace licenses (RocketChat#14851)

reetp · 2019-07-11T13:34:17Z

Just been trying to change the status in open.rocket.chat but can't seem to do it reliably and cannot remove it to set back to default. Something is clearly broken in there.

Not sure whether to open a bug, add to PR #14853 or stay on this?

Hudell · 2019-07-11T13:43:12Z

Since the PRs have already been merged, I think opening a new issue would be ideal.

wreiske · 2019-07-11T16:06:56Z

This may be the issue:

Rocket.Chat/app/lib/server/functions/setStatusText.js

Line 48 in 24ebd2c

    
           export const setStatusText = RateLimiter.limitFunction(_setStatusText, 1, 60000, {

The change status server method is rate limited to once every 60 seconds.

reetp · 2019-07-12T00:32:34Z

As we discovered, it isn't obvious.
Make a change, hit save, realise you made a typo, modify and save, and it stays the same. And you have no idea why.

wreiske · 2019-07-12T00:37:58Z

@reetp if you wouldn't mind taking a minute to open up an issue, refencing that line, I'll get a pull request in to fix it.

Or, you can make a pull request! I would say once every 2 or 3 seconds to account for edits. I was surprised there wasn't any notification about the rate limiter being hit. No "please slow down" messages or anything in console about it hitting the rate limit... hmm. If you open an issue we can discuss what an appropriate rate limit would be for it.

reetp · 2019-07-12T00:39:32Z

OK. Need some Zzzzz - Ill spin it up tomoz

Hudell and others added 30 commits January 5, 2018 20:38

Custom User Status

dc62eea

Set Chosen Custom User Status

58c8d81

Line Endings and Identation

c9538ff

Code Quality

bc7a5b8

Globals

6097fb4

Code Quality

0acbd45

Merge branch 'develop' into custom_user_status

67c4abd

Adjusted for the new sidebar

02931ee

Applying the custom status

89059f6

Merge branch 'develop' into custom_user_status

36ad8ed

Adding user custom status

0d0e3b0

Completed the functionality

8224807

Merge branch 'develop' into custom_user_status

bc6560b

Merge branch 'develop' into custom_user_status

993b122

Applied changes to user status capitalizations

acdc533

Merge branch 'develop' into custom_user_status

948194a

Removed auto translation from popover

d7e7e2e

Merge branch 'develop' into custom_user_status

de14551

Merge branch 'develop' into custom_user_status

0898029

Fixed problems reported on review

353e919

Merge branch 'develop' into custom_user_status

ab0e6dc

Merge branch 'custom_user_status' of github.com:Hudell/Rocket.Chat in…

95eef88

…to custom_user_status

Merge branch 'develop' into custom_user_status

98cc689

backward compatibility

9425459

Merge branch 'develop' into custom_user_status

2a4f1e8

new eslint rules

8fe2520

Popover was being closed whenever the user typed anything, even if th…

79b8005

…e target was an input

User Status Messages

97b305f

Added statusMessage to users api

50bb92b

Added rocket.chat message to status slash command

e61b031

Removed emojione references

ff54c51

wreiske reviewed Jun 19, 2019

View reviewed changes

tassoevan previously approved these changes Jun 21, 2019

View reviewed changes

wreiske previously approved these changes Jun 21, 2019

View reviewed changes

sampaiodiego and others added 2 commits June 21, 2019 16:38

Merge branch 'develop' into custom_user_status

36a3b00

User status of the room leader was not displaying the proper status text

f0692c4

Hudell dismissed stale reviews from wreiske and tassoevan via f0692c4 June 21, 2019 20:39

ggazzo and others added 3 commits June 21, 2019 17:53

fix crud

a939d5c

Fix fields

155d6cb

Change field name

a12788a

sampaiodiego merged commit fbb47b6 into develop Jun 21, 2019

sampaiodiego deleted the custom_user_status branch June 21, 2019 21:56

This was referenced Jun 22, 2019

[NEW] User Status Messages #12710

Closed

[FIX] Custom status fixes #14853

Merged

sampaiodiego mentioned this pull request Jun 28, 2019

Release 1.2.0 #14888

Merged

reetp mentioned this pull request Jul 11, 2019

Additional user statuses #2422

Closed

reetp mentioned this pull request Jul 12, 2019

Custom User Status slow to update #14979

Closed

MarcosSpessatto mentioned this pull request Feb 10, 2020

Creted documentation for users.getStatus and users.setStatus RocketChat/docs-old#1598

Closed

wreiske mentioned this pull request Jan 27, 2021

[FIX] User's Custom Status to be displayed in Direct Chat #20257

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[NEW] Custom User Status #13933

[NEW] Custom User Status #13933

Hudell commented Mar 28, 2019

wreiske Jun 19, 2019

Hudell Jun 19, 2019

wreiske commented Jun 21, 2019

reetp commented Jul 11, 2019

Hudell commented Jul 11, 2019

wreiske commented Jul 11, 2019

reetp commented Jul 12, 2019

wreiske commented Jul 12, 2019

reetp commented Jul 12, 2019

[NEW] Custom User Status #13933

[NEW] Custom User Status #13933

Conversation

Hudell commented Mar 28, 2019

wreiske Jun 19, 2019

Choose a reason for hiding this comment

Hudell Jun 19, 2019

Choose a reason for hiding this comment

wreiske commented Jun 21, 2019

reetp commented Jul 11, 2019

Hudell commented Jul 11, 2019

wreiske commented Jul 11, 2019

reetp commented Jul 12, 2019

wreiske commented Jul 12, 2019

reetp commented Jul 12, 2019