Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Threads and Discussions fixes #14360

Closed
wants to merge 5 commits into from
Closed

[FIX] Threads and Discussions fixes #14360

wants to merge 5 commits into from

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented May 2, 2019

readded threads follow and unfollow Closes #14344
Allow change discussions properties #14027
fix edited messages for nrr disabled
should close #14158

@ggazzo ggazzo changed the title [FIX] Threads follow and unfollow [FIX] Threads and Discussions fixes May 2, 2019
@ggazzo ggazzo requested review from sampaiodiego and tassoevan May 2, 2019 18:01
@ggazzo ggazzo added this to the 1.0.3 milestone May 2, 2019
@rodrigok
Copy link
Member

rodrigok commented May 3, 2019

@ggazzo can you split this in multiple PRs?

@ggazzo
Copy link
Member Author

ggazzo commented May 3, 2019

do you really think we need create 4 prs for 1020 lines, they are small fixes? I'm used to reviewing 4080 files and usually its not a big deal...if you really think it worth, sure I can I'm perfectly able to do :x

@rodrigok
Copy link
Member

rodrigok commented May 3, 2019

@ggazzo it's not due to the code changes, but the description of the changes, you are adding 4 fixes in a single change line in change log that means almost nothing. Would be much better if we have each of them listed in change logs and well described don't you think?

@ggazzo
Copy link
Member Author

ggazzo commented May 6, 2019

I really dont think it worth in that specific case or I would create separated prs on the beginning. but as you wish:
#14387
#14389
#14390
#14391
#14394
#14393

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants