Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Stream not connecting connect when using subdir and multi-instance #14376

Merged
merged 1 commit into from
May 7, 2019
Merged

[FIX] Stream not connecting connect when using subdir and multi-instance #14376

merged 1 commit into from
May 7, 2019

Conversation

geekgonecrazy
Copy link
Contributor

Fixes #13200

@geekgonecrazy geekgonecrazy added this to the 1.0.3 milestone May 3, 2019
@sampaiodiego
Copy link
Member

this is tricky since the websocket path handled by meteor is always on the root.. because of that, this PR doesn't work.. but if the INSTANCE_IP is set to go through the reverse proxy, it needs to have the subdir part.

@geekgonecrazy
Copy link
Contributor Author

That's not the case though. direct IP to IP in a cluster setup it doesn't work. :(

I even tried on my local dev machine and it wouldn't connect. No proxy involved.

If ROOT_URL is set to: http://localhost:3000/rocketchat the instance refuses to respond to anything on / it will only respond on /rocketchat/

With this change locally anyways this worked with 3 instances where as with out this change they all sat there saying connecting.

What can we do different to make this work?

@sampaiodiego
Copy link
Member

sampaiodiego commented May 3, 2019 via email

@geekgonecrazy
Copy link
Contributor Author

geekgonecrazy commented May 3, 2019 •
edited
Loading

Let me know. 😁 I gave the docker image to someone that used subfolder and had a multi-instance in a k8s cluster and this fix seemed to do the trick. Maybe we need to add more conditionals to make it work in other scenarios?

Oh btw when testing locally I had issues apparently meteor registers on a different random port and then proxies 3000 through or something? I had to hop into .meteor/local/build and execute node main.js with PORT=3004 and another terminal with PORT=3005 to truly test it.

link to thread: https://open.rocket.chat/channel/support?msg=xEBfyXCcgiGizrSZf

sampaiodiego
sampaiodiego approved these changes May 6, 2019
View reviewed changes
Copy link
Member

@sampaiodiego sampaiodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it was indeed me testing using meteor command, which have weird bindings.

@geekgonecrazy
Copy link
Contributor Author

Good! 🤗

@rodrigok rodrigok changed the title [FIX] stream connect if using subdir and multi-instance [FIX] Stream not connecting connect when using subdir and multi-instance May 7, 2019
@rodrigok rodrigok merged commit cf1e62a into develop May 7, 2019
@rodrigok rodrigok deleted the fix/13200 branch May 7, 2019 01:28
rodrigok pushed a commit that referenced this pull request May 9, 2019
@geekgonecrazy @rodrigok
If using subpath make sure streams use that also for multi-instance. F…
1cdfee7 
…ixes #13200 (#14376)
@rodrigok rodrigok mentioned this pull request May 9, 2019
Merged
rodrigok added a commit that referenced this pull request May 10, 2019
@rodrigok
Release 1.0.3 (#14446)
f19473c 
* [FIX] New day separator overlapping above system message (#14362)

* Improve German translations (#14351)

* Use the plural for discussions-section in side panel

* Formal and informal translations for 1.0

* fix german typos

* [FIX] Main thread title on replies (#14372)

* fix

* fix test

* fix setting

* Update tests/pageobjects/main-content.page.js

Co-Authored-By: ggazzo <guilhermegazzo@gmail.com>

* Update app/ui-utils/client/lib/RoomHistoryManager.js

Co-Authored-By: ggazzo <guilhermegazzo@gmail.com>

* [FIX] Bell was too small on threads (#14394)

* [FIX] Messages on threads disappearing (#14393)

* fix subscription-changed updating all messages(#14391)

* Fix: Message body was not being updated when user disabled nrr message (#14390)

* [NEW] Allow change Discussion's properties (#14389)

* [FIX] Unnecessary meteor.defer on openRoom (#14396)

* [FIX] more message actions to threads context(follow, unfollow, copy, delete) (#14387)

* added more message actions to threads context

* more actions

* change token name (#14379)

* [FIX] Pressing Enter in User Search field at channel causes reload (#14388)

* Prevent default on enter in User search

* Prevent form submission in membersList

* If using subpath make sure streams use that also for multi-instance.  Fixes #13200 (#14376)

* Revert "[IMPROVE] Use SessionId for credential token in SAML request (#13791)" (#14345)

This reverts commit 3967a74.

* Add fallback to mongo version that doesn't require clusterMonitor role (#14403)

* [FIX] Users actions in administration were returning error (#14400)

* Fix actions collapse into popup in userInfo

* Refactor userActions

* [FIX] Error 400 on send a reply to an old thread (#14402)

* fix error 400 on send a reply to an old thread

* ignoring properly hidden messages

* [FIX] Messages on thread panel were receiving wrong context/subscription  (#14404)

* [FIX] preview pdf its not working (#14419)

* [FIX] renderMessageBody was caching messages in wrong scenarios #14420

* LingoHub Update 🚀 (#14426)

Manual push by LingoHub User: Diego Sampaio.
Project: Rocket.Chat

Made with ❤️ by https://lingohub.com

* [FIX] Mentions message missing 'jump to message' action (#14430)

* fixed context

* threads context

* [FIX] Escape unrecognized slash command message (#14432)

* Add missing german translations (#14386)

* [FIX] IE11 support (#14422)

* Add symlinks to ES6 node_modules imports

* Add URL polyfill for IE11

* Fix thread replies for IE11

* [IMPROVE] allow users to skip activeUsers to be ready (#14431)

* allow users to skip activeUsers to be ready

* Update main.js

* Update app/ui-master/client/main.js

Co-Authored-By: ggazzo <guilhermegazzo@gmail.com>

* [IMPROVE] Don't use regex to find users (#14397)

* Don't use regex to find users

* Invert logic on model methods

* Escape username regex

* Find users in batch

* Use only normalizeMessagesForUser

* Don't ignore username case to get owners on graphql

* Fixes on DAU and MAU aggregations (#14418)

* Fixes on SAU and MAU aggregations

* Report new data from DAU/MAU

* Run tests agains a mongodb container in CI

* Try to run CI correctly

* Fix drop database

* Parse desktop app User Agent correctly

* Fix aggregation of past sessions

* Return past month today

* Fix bug

* Add migration

* Fixed migration

* Migration improvements

* Fix crowd sync by using correct logging method (#14405)

* Fix room names in user info dialogs (#14415)

* Fix discussion name being invalid (#14442)

Closes #14378

* Fix i18n files keys sort (#14433)

* Add script to normalize i18n files

* Fix i18n files

* Set as official script

* Update package-lock.json

* fix (#14443)

* Update threads.css

* Bump version to 1.0.3

* regen changelog
@sampaiodiego sampaiodiego mentioned this pull request May 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sampaiodiego sampaiodiego sampaiodiego approved these changes

@rodrigok rodrigok Awaiting requested review from rodrigok

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.3
Development

Successfully merging this pull request may close these issues.

Clustering not working when using a ROOT_URL with a subpath
3 participants
@geekgonecrazy @sampaiodiego @rodrigok