Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] LDAP usernames get additional '.' if they contain numbers #14644

Merged
merged 3 commits into from
Sep 18, 2019
Merged

[FIX] LDAP usernames get additional '.' if they contain numbers #14644

merged 3 commits into from
Sep 18, 2019

Conversation

Hudell
Copy link
Contributor

@Hudell Hudell commented May 27, 2019

Closes #14608

@Hudell Hudell requested a review from tassoevan May 29, 2019 19:40
@MarcosSpessatto MarcosSpessatto mentioned this pull request Jun 12, 2019
Closed
@Hudell Hudell requested a review from sampaiodiego August 21, 2019 19:35
@sampaiodiego sampaiodiego added this to the 2.1.0 milestone Aug 23, 2019
tassoevan
tassoevan previously requested changes Aug 27, 2019
View reviewed changes
Copy link
Contributor

@tassoevan tassoevan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe app/lib/server/functions/getUsernameSuggestion.js could be updated too.

@Hudell Hudell requested a review from tassoevan August 29, 2019 01:40
@Hudell Hudell dismissed tassoevan’s stale review August 29, 2019 01:40

included the fix there as well.

@sampaiodiego sampaiodiego merged commit 2c75620 into develop Sep 18, 2019
@sampaiodiego sampaiodiego deleted the fix.ldap_usernames_with_numbers branch September 18, 2019 17:16
@sampaiodiego sampaiodiego mentioned this pull request Sep 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sampaiodiego sampaiodiego sampaiodiego approved these changes

@tassoevan tassoevan Awaiting requested review from tassoevan

Assignees
No one assigned
Labels
subj: auth - ldap
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

LDAP usernames get additional '.' if they contain numbers
5 participants
@Hudell @tassoevan @sampaiodiego @engelgabriel @pierre-lehnen-rc