Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NEW] Setting to configure SAML context comparison #15229

Merged
merged 4 commits into from
Sep 19, 2019
Merged

[NEW] Setting to configure SAML context comparison #15229

merged 4 commits into from
Sep 19, 2019

Conversation

Hudell
Copy link
Contributor

@Hudell Hudell commented Aug 21, 2019

Closes #4920

sampaiodiego
sampaiodiego requested changes Sep 19, 2019
View reviewed changes
Copy link
Member

@sampaiodiego sampaiodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we avoid using the whole setting name as i18n key, we'll probably having less keys =)

app/meteor-accounts-saml/server/saml_rocketchat.js Outdated Show resolved Hide resolved
app/meteor-accounts-saml/server/saml_rocketchat.js Outdated Show resolved Hide resolved
app/meteor-accounts-saml/server/saml_rocketchat.js Outdated Show resolved Hide resolved
app/meteor-accounts-saml/server/saml_rocketchat.js Outdated Show resolved Hide resolved
packages/rocketchat-i18n/i18n/en.i18n.json Outdated Show resolved Hide resolved
packages/rocketchat-i18n/i18n/en.i18n.json Outdated Show resolved Hide resolved
packages/rocketchat-i18n/i18n/en.i18n.json Outdated Show resolved Hide resolved
packages/rocketchat-i18n/i18n/en.i18n.json Outdated Show resolved Hide resolved
@pierre-lehnen-rc @sampaiodiego
Use setting values as i18n keys instead of the setting name+value
9b51478 
Co-Authored-By: Diego Sampaio <chinello@gmail.com>
sampaiodiego
sampaiodiego previously approved these changes Sep 19, 2019
View reviewed changes
@sampaiodiego sampaiodiego merged commit ee4c73d into develop Sep 19, 2019
@sampaiodiego sampaiodiego deleted the saml-add-setting-to-configure-context-comparison branch September 19, 2019 20:58
@sampaiodiego sampaiodiego mentioned this pull request Sep 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sampaiodiego sampaiodiego sampaiodiego approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issues with SAML
3 participants
@Hudell @sampaiodiego @pierre-lehnen-rc