-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NEW] Guess a user's name from SAML credentials #15240
[NEW] Guess a user's name from SAML credentials #15240
Conversation
What's with the tap-i18n files? |
@Hudell hmpf - I did not even notice them committed. I’ll remove them once I get back to my computer. Just saw this since the latest release: to me it looks as if those are artifacts which should actually be ignored. Maybe @sampaiodiego can clarify about it. Sent with GitHawk |
We're using rocketchat:tap-i18n now, it's the same package as before but including a few changes. Maybe you still have references to tap-i18n on your fork? |
25c84ef
to
7a44ed0
Compare
@Hudell jup, I know. Don't understand how this was commited though. Rebased to the current develop and committed only the one changed file. |
@sampaiodiego thanks for adapting and merging. I had this on my list for this week, but ... Sent with GitHawk |
No worries @mrsimpson .. I'm preping things for 2.1 release this week, so I did this simple change to include this into the release =) |
What this adds
When authenticated using SAML, users get a username but not a (full) name. That has a couple of nasty side effects since
name
is expected to be available for authenticated users.This PR adds a determination to the user registration via SAML.
How it's done
The username is split by non-word-characters (e. g. the very common
.
) and each resulting word is capitalized.We've been running this for a long time on our branch and did only experience positive effects ;)
Fixes #15236