Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Guess a user's name from SAML credentials #15240

Merged
merged 3 commits into from
Sep 19, 2019

Conversation

mrsimpson
Copy link
Collaborator

@mrsimpson mrsimpson commented Aug 23, 2019

What this adds

When authenticated using SAML, users get a username but not a (full) name. That has a couple of nasty side effects since name is expected to be available for authenticated users.
This PR adds a determination to the user registration via SAML.

How it's done

The username is split by non-word-characters (e. g. the very common .) and each resulting word is capitalized.

We've been running this for a long time on our branch and did only experience positive effects ;)

Fixes #15236

@Hudell
Copy link
Contributor

Hudell commented Aug 23, 2019

What's with the tap-i18n files?

@Hudell Hudell self-assigned this Aug 23, 2019
@Hudell Hudell added this to the 2.1.0 milestone Aug 23, 2019
@mrsimpson
Copy link
Collaborator Author

What's with the tap-i18n files?

@Hudell hmpf - I did not even notice them committed. I’ll remove them once I get back to my computer.
Thanks for notifying!

Just saw this since the latest release: to me it looks as if those are artifacts which should actually be ignored. Maybe @sampaiodiego can clarify about it.

Sent with GitHawk

@Hudell
Copy link
Contributor

Hudell commented Aug 23, 2019

We're using rocketchat:tap-i18n now, it's the same package as before but including a few changes. Maybe you still have references to tap-i18n on your fork?

@mrsimpson mrsimpson force-pushed the core/saml-guess-name branch from 25c84ef to 7a44ed0 Compare August 23, 2019 20:17
@mrsimpson
Copy link
Collaborator Author

@Hudell jup, I know. Don't understand how this was commited though. Rebased to the current develop and committed only the one changed file.

Hudell
Hudell previously approved these changes Aug 24, 2019
@sampaiodiego sampaiodiego merged commit 1db06a5 into RocketChat:develop Sep 19, 2019
@mrsimpson
Copy link
Collaborator Author

@sampaiodiego thanks for adapting and merging. I had this on my list for this week, but ...

Sent with GitHawk

@sampaiodiego
Copy link
Member

No worries @mrsimpson .. I'm preping things for 2.1 release this week, so I did this simple change to include this into the release =)

@sampaiodiego sampaiodiego mentioned this pull request Sep 27, 2019
@mrsimpson mrsimpson deleted the core/saml-guess-name branch December 7, 2020 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Prevent "null is typing"
3 participants