Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: API CORS not working after Cordova being disabled by default #15443

Merged
merged 5 commits into from
Sep 27, 2019

Conversation

rodrigok
Copy link
Member

No description provided.

@rodrigok rodrigok added this to the 2.1.0 milestone Sep 25, 2019
@rodrigok rodrigok requested a review from tassoevan September 25, 2019 19:04
app/api/server/api.js Outdated Show resolved Hide resolved
Co-Authored-By: Tasso Evangelista <tasso.evangelista@rocket.chat>
Copy link
Member

@sampaiodiego sampaiodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also needs to update the PR title to regression

app/api/server/api.js Outdated Show resolved Hide resolved
@rodrigok rodrigok changed the title [FIX] API CORS not working after Cordova being disabled by default Regression: API CORS not working after Cordova being disabled by default Sep 26, 2019
@sampaiodiego sampaiodiego merged commit b62511b into develop Sep 27, 2019
@sampaiodiego sampaiodiego deleted the fix-api-cors branch September 27, 2019 03:08
@sampaiodiego sampaiodiego mentioned this pull request Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants