Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NEW] Assign oldest active user as owner when deleting last room owner #16088

Merged
merged 29 commits into from
Jun 4, 2020
Merged

[NEW] Assign oldest active user as owner when deleting last room owner #16088

merged 29 commits into from
Jun 4, 2020

Conversation

pierre-lehnen-rc
Copy link
Contributor

@pierre-lehnen-rc pierre-lehnen-rc commented Dec 27, 2019 •
edited by sampaiodiego
Loading

Closes #12978
Closes #17805

@protobuff3r
Copy link

we need this urgent because of the European General Data Protection Regulation

@sampaiodiego sampaiodiego mentioned this pull request Feb 26, 2020
Closed
sampaiodiego
sampaiodiego requested changes Apr 18, 2020
View reviewed changes
app/api/server/v1/users.js Outdated Show resolved Hide resolved
app/ui-utils/client/lib/warnUserDeletionMayRemoveRooms.js Outdated Show resolved Hide resolved
app/lib/server/functions/getUserSingleOwnedRooms.js Outdated Show resolved Hide resolved
app/lib/server/functions/getUserSingleOwnedRooms.js Outdated Show resolved Hide resolved
app/lib/server/functions/getUserSingleOwnedRooms.js Outdated Show resolved Hide resolved
app/lib/server/functions/getUserSingleOwnedRooms.js Outdated Show resolved Hide resolved
app/lib/server/functions/relinquishRoomOwnerships.js Outdated Show resolved Hide resolved
app/lib/server/functions/relinquishRoomOwnerships.js Outdated Show resolved Hide resolved
app/lib/server/functions/relinquishRoomOwnerships.js Outdated Show resolved Hide resolved
app/ui-utils/client/lib/warnUserDeletionMayRemoveRooms.js Outdated Show resolved Hide resolved
pierre-lehnen-rc and others added 10 commits April 30, 2020 14:39
@pierre-lehnen-rc
Merge branch 'develop' into assign-oldest-user-as-owner-when-deleting…
94758cb 
…-last-owner
@pierre-lehnen-rc @sampaiodiego
Update app/ui-utils/client/lib/warnUserDeletionMayRemoveRooms.js
0d60832 
Co-authored-by: Diego Sampaio <chinello@gmail.com>
@pierre-lehnen-rc @sampaiodiego
Update app/lib/server/functions/getUserSingleOwnedRooms.js
7b51d35 
Co-authored-by: Diego Sampaio <chinello@gmail.com>
@pierre-lehnen-rc @sampaiodiego
Update app/lib/server/functions/getUserSingleOwnedRooms.js
e4dc582 
Co-authored-by: Diego Sampaio <chinello@gmail.com>
@pierre-lehnen-rc @sampaiodiego
Update app/api/server/v1/users.js
d0681c7 
Co-authored-by: Diego Sampaio <chinello@gmail.com>
@pierre-lehnen-rc
use await to call api method
d4abe74
@pierre-lehnen-rc
Improved subscription query to filter DMs instead of ignoring them later
b69be65
@pierre-lehnen-rc
Replaced 'hasRole' call with new 'subscriptionHasRole' method
daf9aa0
@pierre-lehnen-rc
Removed unused property
c3dd46c
@pierre-lehnen-rc
Stop removing public rooms
d8ac8e2
@pierre-lehnen-rc @sampaiodiego
Update app/lib/server/functions/relinquishRoomOwnerships.js
cee4f95 
Co-authored-by: Diego Sampaio <chinello@gmail.com>
@lgtm-com
Copy link

lgtm-com bot commented May 5, 2020

This pull request introduces 1 alert when merging cee4f95 into 36e72db - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@engelgabriel engelgabriel added this to the 3.3.0 milestone May 21, 2020
@rodrigok rodrigok modified the milestones: 3.3.0, 3.4.0 May 25, 2020
@sampaiodiego sampaiodiego mentioned this pull request Jun 2, 2020
Closed
@lgtm-com
Copy link

lgtm-com bot commented Jun 3, 2020

This pull request introduces 1 alert when merging ce78541 into 68d2577 - view on LGTM.com

new alerts:

  • 1 for Superfluous trailing arguments

@sampaiodiego sampaiodiego force-pushed the assign-oldest-user-as-owner-when-deleting-last-owner branch from 0513ada to 9a6bd86 Compare June 3, 2020 04:29
@sampaiodiego sampaiodiego merged commit 50334ad into develop Jun 4, 2020
@sampaiodiego sampaiodiego deleted the assign-oldest-user-as-owner-when-deleting-last-owner branch June 4, 2020 22:00
ggazzo added a commit that referenced this pull request Jun 8, 2020
@ggazzo
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into feat…
f388313 
…/new-threads

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [FIX] Administration User page blank opening users without email (#17836)
  [REGRESSION] Omnichannel visitor forward was applying wrong restrictions (#17826)
  [NEW] Assign oldest active user as owner when deleting last room owner (#16088)
@sampaiodiego sampaiodiego mentioned this pull request Jun 30, 2020
Merged
@sampaiodiego sampaiodiego mentioned this pull request Sep 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sampaiodiego sampaiodiego sampaiodiego approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.

Improvement - error-user-is-last-owner Deleting the user who owns a private channel
5 participants
@pierre-lehnen-rc @protobuff3r @sampaiodiego @rodrigok @engelgabriel