Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Pressing Cancel while 'deleting by edit' message blocks sending messages #16315

Merged
merged 1 commit into from
Feb 20, 2020
Merged

[FIX] Pressing Cancel while 'deleting by edit' message blocks sending messages #16315

merged 1 commit into from
Feb 20, 2020

Conversation

ritwizsinha
Copy link
Contributor

@ritwizsinha ritwizsinha commented Jan 23, 2020 •
edited by MartinSchoeler
Loading

Closes #15862

out

@ritwizsinha
Copy link
Contributor Author

@MartinSchoeler please review

@ritwizsinha ritwizsinha requested a review from ggazzo January 23, 2020 15:34
@ritwizsinha ritwizsinha changed the title fix bug that was making us to reload the page after cancel was clicke… [FIX] Bug making us to reload the page after cancel was clicke… Jan 30, 2020
@ggazzo ggazzo added this to the 3.0.0 milestone Jan 31, 2020
@ggazzo ggazzo requested a review from MartinSchoeler January 31, 2020 01:44
@MartinSchoeler MartinSchoeler changed the title [FIX] Bug making us to reload the page after cancel was clicke… [FIX] Bug making us to reload the page after cancel was clicked on editing Feb 5, 2020
MartinSchoeler
MartinSchoeler approved these changes Feb 5, 2020
View reviewed changes
Copy link
Contributor

@MartinSchoeler MartinSchoeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the contribution!

@ggazzo ggazzo merged commit 2bd0bec into RocketChat:develop Feb 20, 2020
@rodrigok rodrigok changed the title [FIX] Bug making us to reload the page after cancel was clicked on editing [FIX] Pressing Cancel while 'deleting by edit' message blocks sending messages Mar 26, 2020
@sampaiodiego sampaiodiego mentioned this pull request Apr 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinSchoeler MartinSchoeler MartinSchoeler approved these changes

@ggazzo ggazzo Awaiting requested review from ggazzo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

Pressing Cancel while 'deleting by edit' message blocks sending messages
3 participants
@ritwizsinha @MartinSchoeler @ggazzo