[FIX] When the message is too long declining to send as an attachment does not restore the content into the composer #16332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ishriom53tyagi
changed the title
|
Danish seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
Is it possible to include this in the 3.3 maybe ? I think it's a very important fix. |
# Conflicts: # app/ui-utils/client/lib/modal.js # package-lock.json
rodrigok
approved these changes
Jun 2, 2020
rodrigok
changed the title
dudizilla
approved these changes
Jun 3, 2020
gabriellsh
added a commit
that referenced
this pull request
Jun 4, 2020
…rewrite_admin_sidebar * 'develop' of github.com:RocketChat/Rocket.Chat: [FIX] When the message is too long declining to send as an attachment does not restore the content into the composer (#16332) [IMPROVE][Federation] Add support for _tcp and protocol DNS entries (#17818) Fix the update check not working (#17809) Add Apps-Engine to Engine Versions on History (#17810) [FIX] Link preview containing HTML encoded chars (#16512) [FIX] Email link "go to message" being incorrectly escaped (#17803) [FIX] Error when re-installing an App (#17789) Update Apps-Engine version (#17804) Fix invalid develop payload to release service (#17799)
ggazzo
added a commit
that referenced
this pull request
Jun 4, 2020
…into feat/new-threads * 'feat/new-threads' of github.com:RocketChat/Rocket.Chat: Expand/Collapse ThreadView [FIX] When the message is too long declining to send as an attachment does not restore the content into the composer (#16332)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[FIX] For bug fixes
Closes #16312 Declining to send a message as an attachment destroys its content
This PR include the new id="textarea" with the help of this we can retrieve the input message.