Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Allow to set default department and location sharing on SMS / WhatsApp integration #16557

Merged

Conversation

renatobecker
Copy link
Contributor

@renatobecker renatobecker commented Feb 11, 2020

This PR adds a new setting that allows defining a default Omnichannel department for SMS/WhatsApp integration.
So, if the setting is defined, all new incoming chats received through the SMS integration will be routed to the configured department.

In addition(CLOSES RocketChat/feature-requests#304), a new whatsApp feature will be supported: Inbound/Outbound location sharing.
Both agents and WhatsApp users will be able to share their locations, as displayed below:

Screen Shot 2020-03-13 at 15 07 22

IMG_0363

Also, part of the code has been rewritten to make it simpler and more readable.

@renatobecker renatobecker added this to the 4.0.0 milestone Feb 11, 2020
@renatobecker renatobecker modified the milestones: 4.0.0, 3.1.0 Feb 27, 2020
@CLAassistant
Copy link

CLA assistant check
All committers have signed the CLA.

@renatobecker renatobecker changed the title [NEW] Allow to set default Omnichannel department for SMS/WhatsApp integration [NEW] Allow to set default department and location sharing on SMS / WhatsApp integration Mar 13, 2020
packages/rocketchat-i18n/i18n/pt-BR.i18n.json Outdated Show resolved Hide resolved
packages/rocketchat-i18n/i18n/en.i18n.json Outdated Show resolved Hide resolved
app/sms/server/settings.js Outdated Show resolved Hide resolved
@rodrigok rodrigok merged commit a102c6f into develop Mar 19, 2020
@rodrigok rodrigok deleted the omnichannel/add-default-department-setting-sms-integration branch March 19, 2020 19:58
@sampaiodiego sampaiodiego mentioned this pull request Apr 9, 2020
@richieri
Copy link

Dear @renatobecker ,

I think this pull request may be broking the other sms integration, since it's forcing the integration to declare an "extra" object inside returnData in the "parse" function. I'm currently developing a new integration for other sms/whatsapp service provider and it only works if latitude and longitude are declared.

I think it may be broking the other integrations (but I'm not sure) such as mobex and voxtelesys

@renatobecker
Copy link
Contributor Author

Dear @renatobecker ,

I think this pull request may be broking the other sms integration, since it's forcing the integration to declare an "extra" object inside returnData in the "parse" function. I'm currently developing a new integration for other sms/whatsapp service provider and it only works if latitude and longitude are declared.

I think it may be broking the other integrations (but I'm not sure) such as mobex and voxtelesys

Thanks for point that out, I'll take a look at this case ASAP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow Location sharing via Twilio WhatsApp
4 participants