Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Route to get updated roles after a date #16610

Merged
merged 11 commits into from
Mar 20, 2020
Merged

[NEW] Route to get updated roles after a date #16610

Changes from 3 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
63efe63
[NEW] Route to get updated roles after a date
ashwaniYDV Feb 15, 2020
69a1ab2
some minor fixes
ashwaniYDV Feb 15, 2020
40f6590
changed variable
ashwaniYDV Feb 15, 2020
2e8e718
Merge branch 'develop' of https://github.com/RocketChat/Rocket.Chat i…
ashwaniYDV Feb 27, 2020
7e173b4
added checks to date variable and added function in model
ashwaniYDV Feb 27, 2020
6afd153
Merge branch 'develop' of https://github.com/RocketChat/Rocket.Chat i…
ashwaniYDV Mar 10, 2020
2c64f7b
updated fetch
ashwaniYDV Mar 10, 2020
a6b4a42
updated function of query and added tests
ashwaniYDV Mar 10, 2020
47876eb
minor fix
ashwaniYDV Mar 10, 2020
93c0432
removed unnecisary condition
ashwaniYDV Mar 10, 2020
bca82e4
Final tweaks
MarcosSpessatto Mar 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions app/api/server/v1/roles.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,19 @@ API.v1.addRoute('roles.list', { authRequired: true }, {
},
});

// api to to get updated roles after a date(in ISODate format)
API.v1.addRoute('roles.listByUpdatedDate', { authRequired: true }, {
get() {
check(this.bodyParams, {
updatedAfter: String,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ashwaniYDV can you please validate this query parameter, to make sure it is a valid date? Here we have an example: https://github.com/RocketChat/Rocket.Chat/blob/develop/app/api/server/v1/rooms.js#L34-L43

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 👍

});

const roles = Roles.find({ _updatedAt: { $gte: new Date(this.bodyParams.updatedAfter) } }).fetch();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you create a Model method and put this logic inside it to avoid model logic leak?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes sure. I'll do it :)


return API.v1.success({ roles });
},
});

API.v1.addRoute('roles.create', { authRequired: true }, {
post() {
check(this.bodyParams, {
Expand Down