[NEW] Unread bars on sidebar (#16853) #16862
Conversation
|
|
juzser
force-pushed
the
fix-unread-bars-on-sidebar
branch
from
e0637f2 to
e773c9c
Compare
|
thanks a ton for this 🤗 I've been missing these bars for sooooo long now.. @brunosquadros is this something we're considering to have back? |
|
Yes, no problem, I'm a fan of you guys. I see there is a small problem when you resize the window by height (from have scroll on sidebar to scroll disappeared) so the bar is still there. |
| @@ -64,7 +64,9 @@ | |||
| } | |||
|
|
|||
| & .unread-rooms { | |||
| display: none; | |||
| padding: calc(var(--sidebar-small-default-padding) - 8px); | |||
There was a problem hiding this comment.
What are those 8 pixels? scrollbar?
There was a problem hiding this comment.
No, the .sidebar-item has 3px padding top and the total height is 34px (base on var(--sidebar-item-height-medium)).
So I put the default padding there plus 8px to equal the sidebar-item
|
So do I need to update anything? |
ggazzo
force-pushed
the
fix-unread-bars-on-sidebar
branch
from
5f0b2ff to
4b7ebdf
Compare
|
hey, @juzser thanks for your time, I don't we any changes, I will check with design and we gonna merge your pr :) soon as possible ps: pay attention, you opened a pr to master, you should work always on the develop branch ... thanks again... |
|
Nice. I see you pick my commit to |
ggazzo
changed the title
…to remove-get-dom * 'remove-get-dom' of github.com:RocketChat/Rocket.Chat: [FIX] Notification sounds (#17616) [FIX] Resolve 'app already exists' error on app update (#17544) [NEW] Unread bars on sidebar (#16862) [FIX] Relative image path in oembededUrlWidget (#15902) Regression: Do not show custom status inside sequential messages (#17613)
… integrations * 'integrations' of github.com:RocketChat/Rocket.Chat: [NEW] Add Permissions to deal with Omnichannel visitor past chats history (#17580) [NEW] Add permissions to deal with Omnichannel custom fields (#17567) [FIX] Livechat iframe allow microphone and camera (#9956) [FIX] Do not allow passwords on private channels (#15642) [FIX] Mail Messages > Cannot mail own user. (#17625) [FIX] remove multiple options from dontAskMeAgain (#17514) [FIX] Notification sounds (#17616) [FIX] Resolve 'app already exists' error on app update (#17544) [NEW] Unread bars on sidebar (#16862) [FIX] Relative image path in oembededUrlWidget (#15902) Regression: Do not show custom status inside sequential messages (#17613)
Issue number #16853
li.has-alertthat never be used, toli.sidebar-item--unreadto detect the position of unread message room.updateUnreadBarsfunction when receive new unread message.unread-roomsthat is display: none as default.