Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve: New PR Template #16968

Merged
merged 4 commits into from
May 14, 2020
Merged

Improve: New PR Template #16968

merged 4 commits into from
May 14, 2020

Conversation

regalstreak
Copy link
Contributor

Proposed changes

Let's get the PR template a fresh look. We would need suggestions from maintainers on what more or what changes would be required in the PR template. The goal should be to get as much value out of the PR description as possible. (Same as on React.Native project)

Closes issue(s)

#16967

How to test or reproduce

Open the document on a markdown editor.

Screenshots

Old

image

New

image

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@rodrigok
Copy link
Member

Thanks @regalstreak

Can you add the type of change improvement? Which improves an existent feature.

Would be nice to have a section to write a text to be included on changelog as you can see here on Translation via MS translate item.

@rodrigok rodrigok changed the title [IMPROVEMENT] New PR Template [IMPROVE] New PR Template Mar 27, 2020
@regalstreak
Copy link
Contributor Author

@rodrigok can you review again? Have added the changes

@rodrigok rodrigok changed the title [IMPROVE] New PR Template Improve: New PR Template May 14, 2020
@rodrigok rodrigok merged commit 5bbf9c0 into RocketChat:develop May 14, 2020
ggazzo added a commit that referenced this pull request May 15, 2020
@ggazzo
Merge branch 'admin-refactor' of github.com:RocketChat/Rocket.Chat in…
1649daa 
…to new/oauth_page

* 'admin-refactor' of github.com:RocketChat/Rocket.Chat:
  [FIX] Directory search user placeholder (#17652)
  [NEW] Added "Add custom emoji" link to emoji picker (#16250)
  [FIX] Marketplace tiered pricing plan wording (#17644)
  [FIX] Secret Registration not properly validating Invite Token (#17618)
  Improve: New PR Template (#16968)
  Add engine versions for houston with templates (#17403)
  Use Users.findOneByAppId instead of querying directly (#16480)
  Remove unnecessary setting redefinition (#17587)
  Deprecate compatibility cordova setting (#17586)
ggazzo added a commit that referenced this pull request May 15, 2020
@ggazzo
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into feat…
8c9b05e 
…/new-threads

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Regression: Pressing enter on search reloads the page - admin pages (#17663)
  [NEW] Admin refactor  Second phase (#17551)
  [IMPROVE] Unused styles (#17554)
  [FIX] Directory search user placeholder (#17652)
  [NEW] Added "Add custom emoji" link to emoji picker (#16250)
  [FIX] Marketplace tiered pricing plan wording (#17644)
  [FIX] Secret Registration not properly validating Invite Token (#17618)
  Improve: New PR Template (#16968)
  Add engine versions for houston with templates (#17403)
  Use Users.findOneByAppId instead of querying directly (#16480)
  Remove unnecessary setting redefinition (#17587)
  Deprecate compatibility cordova setting (#17586)
ggazzo added a commit that referenced this pull request May 16, 2020
@ggazzo
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into develop
1d2a6c4 
* 'develop' of github.com:RocketChat/Rocket.Chat: (25 commits)
  [FIX] Not redirecting to `First Channel After Login` on register (#17664)
  Regression: Pressing enter on search reloads the page - admin pages (#17663)
  [NEW] Admin refactor  Second phase (#17551)
  [IMPROVE] Unused styles (#17554)
  [FIX] Directory search user placeholder (#17652)
  [NEW] Added "Add custom emoji" link to emoji picker (#16250)
  [FIX] Marketplace tiered pricing plan wording (#17644)
  [FIX] Secret Registration not properly validating Invite Token (#17618)
  Improve: New PR Template (#16968)
  Add engine versions for houston with templates (#17403)
  Use Users.findOneByAppId instead of querying directly (#16480)
  Remove unnecessary setting redefinition (#17587)
  Deprecate compatibility cordova setting (#17586)
  Hyper.sh went out of business in early 2019 (#17622)
  [NEW] Add Permissions to deal with Omnichannel visitor past chats history (#17580)
  [NEW] Add permissions to deal with Omnichannel custom fields (#17567)
  [FIX] Livechat iframe allow microphone and camera (#9956)
  [FIX] Do not allow passwords on private channels (#15642)
  [FIX] Mail Messages > Cannot mail own user. (#17625)
  [FIX] remove multiple options from dontAskMeAgain (#17514)
  ...
This was referenced May 28, 2020
Merged
Merged
@regalstreak regalstreak mentioned this pull request Jun 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodrigok rodrigok rodrigok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@regalstreak @rodrigok