[FIX] Discussions created from inside DMs were not working and some errors accessing recently created rooms

app/discussion/server/methods/createDiscussion.js

@@ -86,7 +86,8 @@ const create = ({ prid, pmid, t_name, reply, users }) => {
 	// auto invite the replied message owner
 	const invitedUsers = message ? [message.u.username, ...users] : users;
 
-	const discussion = createRoom(p_room.t, name, user.username, [...new Set(invitedUsers)], false, {
+	const type = p_room.t === 'c' ? 'c' : 'p';
+	const discussion = createRoom(type, name, user.username, [...new Set(invitedUsers)], false, {
 		fname: t_name,
 		description: message.msg, // TODO discussions remove
 		topic: p_room.name, // TODO discussions remove

server/startup/migrations/index.js

@@ -180,4 +180,5 @@ import './v179';
 import './v180';
 import './v181';
 import './v182';
+import './v183';
 import './xrun';

server/startup/migrations/v183.js

@@ -0,0 +1,28 @@
+import { Random } from 'meteor/random';
+
+import { Migrations } from '../../../app/migrations';
+import { Rooms, Messages } from '../../../app/models/server';
+
+Migrations.add({
+	version: 183,
+	up() {
+		Rooms.find({ t: 'd', prid: { $exists: true }, uids: [null] }, { fields: { _id: 1 } }).forEach(({ _id }) => {
+			const { u } = Messages.findOne({ drid: _id }, { fields: { u: 1 } }) || {};
+
+			Rooms.update({ _id }, {
+				$set: {
+					t: 'p',
+					name: Random.id(),
+					u,
+					ro: false,
+					default: false,
+					sysMes: true,
+				},
+				$unset: {
+					usernames: 1,
+					uids: 1,
+				},
+			});
+		});
+	},
+});